Skip to content

fix(docs): resolve duplicate IDs and update Bootstrap #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Programador-jr merged 5 commits into from
Nov 4, 2026
Merged

fix(docs): resolve duplicate IDs and update Bootstrap #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d83240f
fix(html): make documentation IDs unique
Programador-jr Nov 4, 2026
e51d95c
chore(deps): update Bootstrap to 5.3.8
Programador-jr Nov 4, 2026
ffdc62c
chore(deps): update Bootstrap to 5.3.8
Programador-jr Nov 4, 2026
36671ba
chore(deps): update Bootstrap to 5.3.8
Programador-jr Nov 4, 2026
7ec291c
test(html): reject duplicate generated element IDs
Programador-jr Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/templates/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-QWTKZyjpPEjISv5WaRU9OFeRpok6YctnYmDr5pNlyT2bRjXh0JMhjY6hW+ALEwIH" crossorigin="anonymous">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-sRIl4kxILFvY47J16cr9ZwB07vP4J8+LH7qKQnuqkuIAvNWLzeN8tE5YBujZqJLB" crossorigin="anonymous">
<link rel="stylesheet" href="/page/css/404.css">
<title>{{t:not_found.title}}</title>
</head>
Expand Down
20 changes: 10 additions & 10 deletions docs/templates/docs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
<title> {{t:page.title}} </title>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.7.2/css/all.min.css">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/atom-one-dark.min.css">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha3/dist/css/bootstrap.min.css" rel="stylesheet">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-sRIl4kxILFvY47J16cr9ZwB07vP4J8+LH7qKQnuqkuIAvNWLzeN8tE5YBujZqJLB" crossorigin="anonymous">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap-icons@1.11.3/font/bootstrap-icons.min.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/flag-icons@7.2.3/css/flag-icons.min.css">
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha3/dist/js/bootstrap.bundle.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/js/bootstrap.bundle.min.js" integrity="sha384-FKyoEForCGlyvwx9Hj09JcYn3nv7wiPVlz7YYwJrWVcXK/BmnVDxM+D2scQbITxI" crossorigin="anonymous"></script>
<link rel="stylesheet" href="/page/css/docs.css">
</head>
<body>
Expand Down Expand Up @@ -105,11 +105,11 @@
</div>

<div class="nav-item">
<a class="nav-link nested-link" data-bs-toggle="collapse" href="#item-3">
<a class="nav-link nested-link" data-bs-toggle="collapse" href="#item-3-navigation" aria-controls="item-3-navigation" aria-expanded="false">
<i class="bi bi-images"></i>
<span data-translate="menu.exercise_images">{{t:menu.exercise_images}}</span>
</a>
<div class="collapse" id="item-3">
<div class="collapse" id="item-3-navigation">
<nav class="nav flex-column">
<a class="nav-link nested-link sublink" href="#item-3-1" data-translate="menu.images_structure">{{t:menu.images_structure}}</a>
</nav>
Expand Down Expand Up @@ -231,7 +231,7 @@ <h6 class="response-samples" data-translate="response.samples">{{t:response.samp
<button class="nav-link button bg-danger border-danger all-400 btn" id="Get-400-tab" data-bs-toggle="tab" data-bs-target="#Get-400" data-group="Get" data-value="Get-400" type="button" role="tab" aria-controls="Get-400" aria-selected="false"><strong>400 Bad Request</strong></button>
</li>
</ul>
<div class="tab-content" id="all{{t:exercises.count}}TabContent">
<div class="tab-content" id="getTabContent">
<div class="tab-pane fade show active" id="Get-200" role="tabpanel" aria-labelledby="Get-200-tab">
<pre><code class="json">{{{example_get_200}}}</code></pre>
</div>
Expand Down Expand Up @@ -340,7 +340,7 @@ <h6 class="response-samples" data-translate="response.samples">{{t:response.samp
<button class="nav-link button bg-danger border-danger all-400 btn" data-group="{{t:menu.lang}}" data-value="{{t:menu.lang}}-200" id="{{t:menu.lang}}-400-tab" data-bs-toggle="tab" data-bs-target="#{{t:menu.lang}}-400" type="button" role="tab" aria-controls="{{t:menu.lang}}-400" aria-selected="false"><strong>400 Bad Request</strong></button>
</li>
</ul>
<div class="tab-content" id="all{{t:exercises.count}}TabContent">
<div class="tab-content" id="languageTabContent">
<div class="tab-pane fade show active" id="{{t:menu.lang}}-200" role="tabpanel" aria-labelledby="{{t:menu.lang}}-200-tab">
<pre><code class="json">{{{example_lang_200}}}</code></pre>
</div>
Expand Down Expand Up @@ -437,7 +437,7 @@ <h6 class="response-samples" data-translate="response.samples">{{t:response.samp
<button class="nav-link button bg-danger border-danger all-400 btn" data-group="{{t:menu.fields}}" data-value="{{t:menu.fields}}-200" id="{{t:menu.fields}}400-tab" data-bs-toggle="tab" data-bs-target="#{{t:menu.fields}}400" type="button" role="tab" aria-controls="{{t:menu.fields}}400" aria-selected="false"><strong>400 Bad Request</strong></button>
</li>
</ul>
<div class="tab-content" id="all{{t:exercises.count}}TabContent">
<div class="tab-content" id="fieldsTabContent">
<div class="tab-pane fade show active" id="{{t:menu.fields}}200" role="tabpanel" aria-labelledby="{{t:menu.fields}}200-tab">
<pre><code class="json">{{{example_fields_200}}}</code></pre>
</div>
Expand Down Expand Up @@ -545,7 +545,7 @@ <h6 class="response-samples" data-translate="response.samples">{{t:response.samp
<button class="nav-link button bg-danger border-danger all-400 btn" data-group="{{t:menu.page}}" data-value="{{t:menu.page}}-200" id="{{t:menu.page}}400-tab" data-bs-toggle="tab" data-bs-target="#{{t:menu.page}}400" type="button" role="tab" aria-controls="{{t:menu.page}}200" aria-selected="false"><strong>400 Bad Request</strong></button>
</li>
</ul>
<div class="tab-content" id="all{{t:exercises.count}}TabContent">
<div class="tab-content" id="pageTabContent">
<div class="tab-pane fade show active" id="{{t:menu.page}}200" role="tabpanel" aria-labelledby="{{t:menu.page}}200-tab">
<pre><code class="json">{{{example_page_200}}}</code></pre>
</div>
Expand Down Expand Up @@ -770,7 +770,7 @@ <h6 class="response-samples" data-translate="response.samples">{{t:response.samp
</li>
</ul>

<div class="tab-content" id="all{{t:exercises.count}}TabContent">
<div class="tab-content" id="filtersTabContent">
<div class="tab-pane fade show active" id="Filters200" role="tabpanel" aria-labelledby="Filters200-tab">
<pre><code class="json">{{{example_filters_200}}}</code></pre>
</div>
Expand Down Expand Up @@ -914,7 +914,7 @@ <h6 class="response-samples" data-translate="response.samples">{{t:response.samp
</button>
</li>
</ul>
<div class="tab-content" id="all{{t:exercises.count}}TabContent">
<div class="tab-content" id="imageTabContent">
<div class="tab-pane fade show active" id="Image-400" role="tabpanel" aria-labelledby="Image-400-tab">
<pre><code class="json">{{{example_image_404}}}</code></pre>
</div>
Expand Down
4 changes: 2 additions & 2 deletions docs/templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap-icons@1.11.3/font/bootstrap-icons.min.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/flag-icons@7.2.3/css/flag-icons.min.css">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha3/dist/css/bootstrap.min.css" rel="stylesheet">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-sRIl4kxILFvY47J16cr9ZwB07vP4J8+LH7qKQnuqkuIAvNWLzeN8tE5YBujZqJLB" crossorigin="anonymous">
<link rel="stylesheet" href="/page/css/docs.css">
<link href="/page/css/start.css" rel="stylesheet">
</head>
Expand Down Expand Up @@ -189,7 +189,7 @@ <h4 class="mt-3" data-translate="free.tier">{{t:free.tier}}</h4>
</footer>

<script src="/page/js/script.js"></script>
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha3/dist/js/bootstrap.bundle.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/js/bootstrap.bundle.min.js" integrity="sha384-FKyoEForCGlyvwx9Hj09JcYn3nv7wiPVlz7YYwJrWVcXK/BmnVDxM+D2scQbITxI" crossorigin="anonymous"></script>
<script src="/page/js/dark-light.js"></script>
</body>
</html>
4 changes: 2 additions & 2 deletions docs/templates/legal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<title>{{legal_title}} | MuscleLib</title>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap-icons@1.11.3/font/bootstrap-icons.min.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/flag-icons@7.2.3/css/flag-icons.min.css">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha3/dist/css/bootstrap.min.css" rel="stylesheet">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-sRIl4kxILFvY47J16cr9ZwB07vP4J8+LH7qKQnuqkuIAvNWLzeN8tE5YBujZqJLB" crossorigin="anonymous">
<link rel="stylesheet" href="/page/css/docs.css">
</head>
<body class="light-theme">
Expand Down Expand Up @@ -70,7 +70,7 @@
</nav>
</footer>

<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha3/dist/js/bootstrap.bundle.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/js/bootstrap.bundle.min.js" integrity="sha384-FKyoEForCGlyvwx9Hj09JcYn3nv7wiPVlz7YYwJrWVcXK/BmnVDxM+D2scQbITxI" crossorigin="anonymous"></script>
<script src="/page/js/script.js"></script>
<script src="/page/js/dark-light.js"></script>
</body>
Expand Down
17 changes: 17 additions & 0 deletions tools/validate-locales.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,21 @@ function extractIds(html) {
);
}

function validateUniqueIds(html, file) {
const ids = [...html.matchAll(/\bid=["']([^"']+)["']/gi)].map((match) => match[1]);
const seen = new Set();
const duplicates = new Set();

for (const id of ids) {
if (seen.has(id)) duplicates.add(id);
seen.add(id);
}

if (duplicates.size) {
fail(`Duplicate HTML IDs in ${file}: ${[...duplicates].join(", ")}`);
}
}

function assertNoUnresolvedPlaceholders(html, file) {
const unresolved = html.match(/\[\[[\w.]+\]\]|\{\{\{?[\w.:]+\}?\}\}?/g);
if (unresolved?.length) {
Expand Down Expand Up @@ -154,6 +169,7 @@ for (const lang of LANGS) {
}

assertNoUnresolvedPlaceholders(html, relativePath);
validateUniqueIds(html, relativePath);
validateInternalLinks(html, relativePath, `/${lang}/${page}`);

if (page === "docs.html") {
Expand All @@ -175,6 +191,7 @@ if (!/<html\b[^>]*\blang=["']en["']/i.test(notFoundHtml)) {
fail("Invalid or missing lang attribute in 404.html");
}
assertNoUnresolvedPlaceholders(notFoundHtml, "404.html");
validateUniqueIds(notFoundHtml, "404.html");
validateInternalLinks(notFoundHtml, "404.html", "/404");

console.log(
Expand Down
Loading