Skip to content

Add check-gradient-lhs caller - #558

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv
Nov 8, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Wires Morrison-Lab/gha's check-gradient-lhs (gha#1538, from psw#488).

Important

This PR waits on the v3 tag slide, which carries gha#1652. Until then check-caller-permissions fails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.

Adds .github/workflows/check-gradient-lhs.yml, warn-only (fail is off). The annotation gate here uses workflows: ["*"], so it needs no listing. Infrastructure only.


Generated by Claude Code

Wires Morrison-Lab/gha's check-gradient-lhs (psw#488, gha#1538): a line a
PR adds that says "the gradient is ..." should write the gradient symbol
as the left-hand side of its equation. Warn-only. Part of
Morrison-Lab/gha#1654.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9qHcYVZ9pfvuZZYpVo
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Review of PR #558: add check-gradient-lhs.yml caller workflow

The PR adds one file, .github/workflows/check-gradient-lhs.yml. It is a caller for the reusable workflow Morrison-Lab/gha/.github/workflows/check-gradient-lhs.yml@v3. The file sets contents: read and passes whole-tree and paths-ignore, the same way check-avoided-words.yml does.

I found no blocking issues.

Not verified

  • The local gha reference checkout has no check-gradient-lhs.yml, so I could not confirm that @v3 exposes it. I also could not confirm it accepts the whole-tree and paths-ignore inputs. If @v3 lacks the workflow, every PR run fails. Please confirm that gha#1538 is released under v3.
  • The header comment says the check "warns rather than fails" and mentions a fail: true option, but the caller sets no fail input. This works only if the reusable workflow defaults to warning. check-avoided-words.yml sets fail: false explicitly. Setting it here too would make the intent visible and stop it depending on the default (suggestion).

No math, prose, .qmd, or bibliography content changed, so the macro and Quarto checks do not apply.

Verdict

Ready for merge, once the @v3 availability above is confirmed.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "9303e358f1cf682e33dcbdf1258ef3a44f8c6bf7",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The new caller workflow check-gradient-lhs.yml mirrors sibling callers such as check-avoided-words.yml, with read-only permissions and pull_request plus workflow_dispatch triggers. The only unconfirmed point is that the reusable workflow is absent from the local gha reference checkout.",
  "holistic_assessment": "Scope is a single CI caller file with no content changes. Regression risk is low because the check is described as warn-only. Validation of the v3 tag and the default for the fail input depends on the upstream gha repository."
}

Reviewed commit: 9303e35

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2068 (review) — run

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/sds/pr-preview/pr-558/

Built to branch gh-pages at 2026-11-08 05:57 UTC.

@d-morrison
d-morrison merged commit 697cf4c into main Nov 8, 2026
45 of 46 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-yoywtv branch November 8, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants