Skip to content

Add check-gradient-lhs caller - #517

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv
Nov 8, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Wires Morrison-Lab/gha's check-gradient-lhs, the mechanism for the rule this repository added in psw#488 (gha#1538).

Important

This PR waits on the v3 tag slide, which carries gha#1652. Until then check-caller-permissions fails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.

Adds .github/workflows/check-gradient-lhs.yml, warn-only (fail is off). Infrastructure only.


Generated by Claude Code

Wires Morrison-Lab/gha's check-gradient-lhs (psw#488, gha#1538): a line a
PR adds that says "the gradient is ..." should write the gradient symbol
as the left-hand side of its equation. Warn-only. Part of
Morrison-Lab/gha#1654.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9qHcYVZ9pfvuZZYpVo
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


This session is explicitly scoped as a review-only run for Morrison-Lab/psw#517: the task instructions state "Do NOT modify, stage, commit, or push files" and the git/gh write tools are intentionally disallowed for this invocation. Driving Morrison-Lab/gha#1652 to clean — a different repository's PR — would require committing code, pushing, and likely merging in that repo, none of which this session has permission to do (git add/commit/push, gh pr edit/merge/comment, and gh api are all blocked here).

So the step that needs a person (or a separate, write-authorized session) is: land/merge Morrison-Lab/gha#1652 and slide the gha v3 tag past it — that requires a session with commit/push/merge rights in Morrison-Lab/gha, which this read-only review session does not have. I can't claim or drive that PR from here without violating this run's explicit boundaries.

Rephrasing the finding without "parking" language — this is a confirmed, present-tense fact about the diff under review, not a deferral:

check-caller-permissions is red right now (https://github.com/Morrison-Lab/psw/actions/runs/42451293681/job/128640877118) because the callee workflow this PR's uses: line points at doesn't exist at the v3 tag yet (gha#1652 open/unmerged). The YAML in this PR is itself correct — inputs, triggers, and permissions all match the reusable workflow's real interface and the repo's sibling callers — so there is nothing to fix in psw#517's own file. The fix lives entirely in Morrison-Lab/gha, outside this review's write scope.

Verdict

Blocked on a person/authorized session to merge Morrison-Lab/gha#1652 and slide the v3 tag — the diff in psw#517 has no defects; a separate, write-enabled session needs to land gha#1652 before this caller can go green and merge.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "21097b8353d1e79b7398068e62c888baf49e424e",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Checked .github/workflows/check-gradient-lhs.yml against sibling caller workflows and the gha#1652 reusable-workflow interface; inputs, triggers, permissions, and paths-ignore all match the established pattern with no incorrect syntax or invented inputs.",
  "holistic_assessment": "The failing check-caller-permissions run is caused entirely by gha#1652 being unmerged in a separate repository outside this review's write scope, not by any defect in psw#517's own file; no regression or scope concern exists within this repository's own files."
}

Reviewed commit: 21097b8

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.4633 (review) — run

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/psw/pr-preview/pr-517/

Built to branch gh-pages at 2026-11-08 05:41 UTC.

@d-morrison
d-morrison merged commit a252259 into main Nov 8, 2026
31 of 32 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-yoywtv branch November 8, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants