Repository navigation
Add a figure to the best-constant example - #342
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9ohb8bijGhgKPdUpzm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…t c = 20 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9ohb8bijGhgKPdUpzm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Base automatically changed from
claude/project-thread-xl7r9m-restructure
to
main
November 6, 2026 09:45
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9ohb8bijGhgKPdUpzm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hBCtw8LajYGV7TiWG1zum
Contributor
|
Claude finished review — View run I fetched PR #342 live just now. It is open, not a draft, and not merged. Its head is Confirming review: the new head I read the diff and the surrounding subfile. I did not render the page or run the linters.
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "11d9458a4a818b8ed7419b6c25c4a198273fd7c6",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The figure chunk in _subfiles/_exm-best-constant-auto.qmd uses only variables from the earlier chunk, has a unique fig label, aligned point labels, and accurate alt text; no defects found.",
"holistic_assessment": "The head adds only a clean merge of main to an already reviewed single-file change, with no scope creep, link changes, math, or workflow impact, so the earlier clean verdict stands."
}Reviewed commit: 11d9458 |
Contributor
Contributor
Built to branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked on #334, which must land first.
Part of #329.
check-exm-figureswarned that#exm-best-constant-autohad no figure. The example now plots the expected squared error of every constant from 10 to 40 againstc, computed from the 392 cars indata/auto.csv, and marks the mean, the median andc = 20from the table. The curve bottoms out at the mean (c= 23.4, error 60.76), which is the point of the example. I ran the chunks locally against the data and checked the rendered plot: the three labels do not overlap.Generated by Claude Code