Skip to content

Add check-gradient-lhs caller - #694

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv
Nov 8, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Wires Morrison-Lab/gha's check-gradient-lhs (gha#1538, from psw#488).

Important

This PR waits on the v3 tag slide, which carries gha#1652. Until then check-caller-permissions fails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.

Adds .github/workflows/check-gradient-lhs.yml, warn-only (fail is off). This repository has no annotation gate. Infrastructure only.


Generated by Claude Code

Wires Morrison-Lab/gha's check-gradient-lhs (psw#488, gha#1538): a line a
PR adds that says "the gradient is ..." should write the gradient symbol
as the left-hand side of its equation. Warn-only. Part of
Morrison-Lab/gha#1654.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9qHcYVZ9pfvuZZYpVo
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


This review run is read-only. I can't merge gha#1652 or slide the v3 tag, so I couldn't clear the blocker myself. The tag slide needs someone with push rights on Morrison-Lab/gha, and that person has to do it.

The review is unchanged. The caller file has no defect, but the workflow it calls doesn't exist at @v3 yet. gha#1652 is still open.

This PR has no merge conflicts: mergeable is MERGEABLE, the base branch is main, and mergeStateStatus is BLOCKED, which fits the failing 404 check.

Verdict

Needs more work. The PR can't merge until gha#1652 is merged and the v3 tag has been moved by a person with push rights on gha.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "b11660df1d513ad3c17d5c72ebe61dda0eb9e167",
  "verdict": "NOT_CLEAN",
  "findings": [
    {
      "file": ".github/workflows/check-gradient-lhs.yml",
      "line": 17,
      "category": "bug",
      "message": "The reusable workflow Morrison-Lab/gha check-gradient-lhs.yml@v3 returns 404 on both v3 and main. Its gha PR #1652 is still open, so merging now makes this check and check-caller-permissions fail. Merge only after gha#1652 merges and the v3 tag slides."
    }
  ],
  "detailed_assessment": "The caller workflow in .github/workflows/check-gradient-lhs.yml references a reusable workflow at gha@v3 that does not exist yet (404 on v3 and main), and gha#1652 is still open, so every PR run would fail until the tag slides.",
  "holistic_assessment": "The change is small, correctly scoped and warn-only, with sensible ignore paths and the same layout as the other gha callers. Its only problem is the ordering dependency on the gha release, which the PR description already documents. The PR has no merge conflicts, and its BLOCKED merge state matches the failing check."
}
@claude address review comments in [this review](https://github.com/Morrison-Lab/mds/pull/694)

Reviewed commit: b11660d

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2571 (review) — run

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Prior verdict was Needs more work (2026-11-08 summary). That blocker is now cleared, so I'm updating it.

The only finding was that Morrison-Lab/gha/.github/workflows/check-gradient-lhs.yml@v3 returned 404 because gha#1652 was still open. I re-checked:

  • gha#1652 is now MERGED.
  • The local gha reference checkout has check-gradient-lhs.yml under .github/workflows/, and its HEAD carries the v3 tag. I could not read the v3 ref directly, so the tag position is inferred from the checkout.
  • No check on the PR is failing. check-caller-permissions passes. build and claude-review were still pending, and I did not see a check-gradient-lhs job listed.
  • The PR head is still b11660df1d513ad3c17d5c72ebe61dda0eb9e167, so the diff hasn't changed.

I re-read the diff, which adds one caller workflow at .github/workflows/check-gradient-lhs.yml, and found nothing else:

  • It is scoped to pull_request plus workflow_dispatch, so it has no push trigger.
  • Permissions are least-privilege (contents: read).
  • It follows the same uses: layout as the other gha callers.
  • whole-tree is set only on manual runs.
  • The ignore paths cover vendored and generated content.
  • The comments describe what the workflow does.
  • It adds no .qmd prose or math, so the line-break, content and macro rules don't apply.

Verdict

Ready for merge. The earlier blocker is gone, and I found no new issues. Confirm the first PR run starts the check-gradient-lhs job before merging.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "b11660df1d513ad3c17d5c72ebe61dda0eb9e167",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The caller workflow check-gradient-lhs.yml now references a reusable workflow that exists, since gha#1652 merged, and check-caller-permissions passes with no failing checks.",
  "holistic_assessment": "The change is small, warn-only and scoped correctly with no push trigger; the earlier ordering dependency on the gha release is resolved, and the diff is unchanged since the prior review."
}

Reviewed commit: b11660d

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1982 (review) — run

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/mds/pr-preview/pr-694/

Built to branch gh-pages at 2026-11-08 06:26 UTC.

@d-morrison
d-morrison merged commit 98e8740 into main Nov 8, 2026
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants