Repository navigation
Add check-gradient-lhs caller - #694
Conversation
Wires Morrison-Lab/gha's check-gradient-lhs (psw#488, gha#1538): a line a PR adds that says "the gradient is ..." should write the gradient symbol as the left-hand side of its equation. Warn-only. Part of Morrison-Lab/gha#1654. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9qHcYVZ9pfvuZZYpVo
|
Claude finished review — View run This review run is read-only. I can't merge gha#1652 or slide the The review is unchanged. The caller file has no defect, but the workflow it calls doesn't exist at This PR has no merge conflicts: VerdictNeeds more work. The PR can't merge until gha#1652 is merged and the Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "b11660df1d513ad3c17d5c72ebe61dda0eb9e167",
"verdict": "NOT_CLEAN",
"findings": [
{
"file": ".github/workflows/check-gradient-lhs.yml",
"line": 17,
"category": "bug",
"message": "The reusable workflow Morrison-Lab/gha check-gradient-lhs.yml@v3 returns 404 on both v3 and main. Its gha PR #1652 is still open, so merging now makes this check and check-caller-permissions fail. Merge only after gha#1652 merges and the v3 tag slides."
}
],
"detailed_assessment": "The caller workflow in .github/workflows/check-gradient-lhs.yml references a reusable workflow at gha@v3 that does not exist yet (404 on v3 and main), and gha#1652 is still open, so every PR run would fail until the tag slides.",
"holistic_assessment": "The change is small, correctly scoped and warn-only, with sensible ignore paths and the same layout as the other gha callers. Its only problem is the ordering dependency on the gha release, which the PR description already documents. The PR has no merge conflicts, and its BLOCKED merge state matches the failing check."
}Reviewed commit: b11660d |
|
Claude finished review — View run Prior verdict was Needs more work (2026-11-08 summary). That blocker is now cleared, so I'm updating it. The only finding was that
I re-read the diff, which adds one caller workflow at
VerdictReady for merge. The earlier blocker is gone, and I found no new issues. Confirm the first PR run starts the Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "b11660df1d513ad3c17d5c72ebe61dda0eb9e167",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The caller workflow check-gradient-lhs.yml now references a reusable workflow that exists, since gha#1652 merged, and check-caller-permissions passes with no failing checks.",
"holistic_assessment": "The change is small, warn-only and scoped correctly with no push trigger; the earlier ordering dependency on the gha release is resolved, and the diff is unchanged since the prior review."
}Reviewed commit: b11660d |
Built to branch |
Wires
Morrison-Lab/gha'scheck-gradient-lhs(gha#1538, from psw#488).Important
This PR waits on the
v3tag slide, which carries gha#1652. Until thencheck-caller-permissionsfails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.Adds
.github/workflows/check-gradient-lhs.yml, warn-only (failis off). This repository has no annotation gate. Infrastructure only.Generated by Claude Code