Repository navigation
Pin r-lib/actions to the v2.14.0 commit SHA - #686
Open
d-morrison wants to merge 1 commit into
Open
d-morrison wants to merge 1 commit into
d-morrison wants to merge 1 commit into
Conversation
A floating v2 tag runs whatever it is re-pointed to, with no review. gha pins the same SHA; this matches it. Part of Morrison-Lab/gha#1594. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nsqVjb7QTEYNzGgFj
Contributor
|
Claude finished review — View run I read PR #686 live just now. It is open, not a draft, not merged, and its head is still The review stands. The diff only pins four VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "e45b505ace78cb492dc9648ba1e1486250381476",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Checked the three workflow files; the pinned SHA f9a764fe resolves to the r-lib/actions v2.14.0 tag and both setup-r and setup-pandoc live in that repo.",
"holistic_assessment": "A pure supply-chain pinning change with no input changes and no content or math edits, so there is little regression risk to the publish and preview pipelines."
}Reviewed commit: e45b505 |
Contributor
Contributor
Built to branch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ezra · project thread
Why
The workflows here called
r-lib/actions/...@v2, a floating tag. A re-pointed tag would run in this repository with no review. Morrison-Lab/gha already pins every r-lib action to the v2.14.0 commit, and this change matches it.Part of Morrison-Lab/gha#1594.
What
Each
r-lib/actions/<action>@v2reference becomes@f9a764fea8d5c63df6ef9a5c7795bf7deb5d7e05 # v2.14.0(the commit gha uses). 3 workflow files, no other change.Checks
grep -rn 'r-lib/actions.*@v2' .githubhas no match.v2.14.0commit in r-lib/actions (git rev-parse f9a764f).Generated by Claude Code