[d-morrison]

Wires Morrison-Lab/gha's check-gradient-lhs (gha#1538, from psw#488).

Important

This PR waits on the v3 tag slide, which carries gha#1652. Until then check-caller-permissions fails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.

Adds .github/workflows/check-gradient-lhs.yml, warn-only (fail is off), ignoring _subfiles/** as this repository's other prose callers do. This repository has no annotation gate. Infrastructure only.

---

Generated by Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[github-actions]

Claude finished review — View run

---

Review: #106 — Add check-gradient-lhs caller

Scope: single new file, .github/workflows/check-gradient-lhs.yml (20 lines), a thin caller for Morrison-Lab/gha's new check-gradient-lhs reusable workflow. Infrastructure-only, no .qmd/prose changes.

Verification performed

• Confirmed the reusable workflow and its inputs (whole-tree, paths-ignore, fail, globs, python-version, base-ref) are real by reading Morrison-Lab/gha#1652 (open, unmerged) — the inputs this caller sets (whole-tree, paths-ignore) match exactly.
• Confirmed the referenced issues are real and consistent with the PR's claims: gha#1538 (the check proposal), psw#488 (the style rule), gha#1654 (the rollout tracking issue, which lists mcs as one of the seven notes-repo callers to add), and gha#1652 (the PR adding the reusable workflow, currently open — so the PR body's "waits on the v3 tag slide" caveat is accurate, not hedging).
• Checked this PR's own CI (gh pr checks): all checks pass, including lint / lint-workflows (actionlint + zizmor), and no check-gradient-lhs job ran — expected, since GitHub doesn't invoke a pull_request-triggered workflow introduced by the same PR when it isn't yet on the base branch. So the disclosed "check-caller-permissions 404" risk is about an out-of-repo mechanism (per the tracking issue, a separate "runner thread" slide), not something visible or blocking in this PR's checks.
• Diffed against this repo's existing @v3 callers for the same family of diff-scoped prose checks (check-avoided-words.yml, check-exm-figures.yml, check-div-ids.yml, check-local-macros.yml). Structure, trigger set (pull_request + workflow_dispatch, no push), job-level permissions: contents: read, and the whole-tree: ${{ github.event_name == 'workflow_dispatch' }} idiom all match house convention exactly.

Minor, non-blocking observation

• .github/workflows/check-gradient-lhs.yml and the PR body both say the _subfiles/** paths-ignore entry follows "this repository's other prose callers" (plural). Checking every caller in .github/workflows/, only check-avoided-words.yml currently excludes _subfiles/**; the other prose-ish callers (check-results-in-remarks.yml, check-definition-expectation.yml) ignore _extensions/**,**/outtakes/**,latex-macros/** but not _subfiles/**. The rationale (verbatim _subfiles copies from mds, revised in a later phase per mcs#60) is sound and does apply here, so this isn't wrong, just a slight overstatement of precedent — not worth blocking on.

No bugs, no CLAUDE.md violations, no hallucinated symbols/inputs/issues found. The file mirrors an established, working pattern in this repo precisely, and the one real limitation (the @v3 tag not yet carrying the new reusable workflow) is disclosed honestly with a tracking issue rather than glossed over.

Verdict

Ready for merge

Structured Review Data (JSON)

{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "230781fe0c03462e39c1fa4ff505d6e402c327fb",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Reviewed .github/workflows/check-gradient-lhs.yml line by line against Morrison-Lab/gha PR 1652's reusable workflow inputs and found no incorrect fields, no syntax issues, and matching trigger/permissions conventions used by sibling caller workflows in this repo.",
  "holistic_assessment": "Scope stays infrastructure-only as described, integrates with the gha family's established caller pattern, the one known limitation (v3 tag not yet sliding) is disclosed with a tracking issue, and CI on the PR already passes including lint-workflows validation."
}

Reviewed commit: 230781f

[github-actions]

💰 Cost: $0.5621 (review) — run

[github-actions]

PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/mcs/pr-preview/pr-106/

_{Built to branch gh-pages at 2026-11-08 05:51 UTC.}