Repository navigation
Write the base-2 entropy, cross-entropy and divergence with their macros - #108
d-morrison wants to merge 4 commits into
Conversation
The fragments wrote them as H_2 and D_2, which reads as the Renyi entropy of order 2 (collision entropy) used elsewhere on the site. Use \entropyf, \crossentropyf and \kldivf, and say base-2 logarithms in the prose. Closes #106. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9puSJHfSFxeRBZUfnt
Link bits, binary digits, uniquely decodable code, loss and logarithms on the lines of the base-2 notation change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9puSJHfSFxeRBZUfnt
|
/review Requesting the Claude review on the current head. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9puSJHfSFxeRBZUfnt
|
/review Merged Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The Claude review found the base-2 proof line holding three clauses. Break it, the statement line beside it, and the loss line at clauses. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9puSJHfSFxeRBZUfnt
|
/review Fixed the blocking finding in Generated by Claude Code |
|
Claude finished review — View run I reviewed commit Prior blocking finding is fixed.
Rule 12 check. Each remaining line holds at most one clause. The split Markup. Link targets are unchanged. The split Markdown link text in Carried-over suggestion, non-blocking. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "eeb5ceca144e71773ac2041707598914dc97a60f",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The new commit breaks the three-clause proof line in _thm-kl-divergence-nonnegative.qmd after each clause and splits the long loss-link line in _rem-cross-entropy-loss.qmd; links and macros are unchanged.",
"holistic_assessment": "The commit addresses the one blocking line-break finding from the previous round with no wording or scope change, so the earlier macro, anchor and base-2 checks still stand."
}Reviewed commit: eeb5cec |
Built to branch |
|
Annotation review for head agy's quota is exhausted, so I ran the checker with Posted by Claude Code (AI agent) --- not written by a human. |
Closes #106.
Seven fragments wrote the Shannon entropy, cross-entropy and divergence as
H_2(p),H_2(p, q)andD_2(p \,\|\, q), where the 2 means base-2 logarithms. The same site writes the Rényi entropy of order 2 as\renyientropyf{2}{X}, which prints the same glyph, so a reader could not tell the two apart. They now use the existing macros\entropyf,\crossentropyfand\kldivf, and the prose says "base-2 logarithms" where each result is stated.Files:
_thm-source-coding,_thm-wrong-code,_rem-cross-entropy-wrong-code,_exm-cross-entropy-decomposition,_rem-cross-entropy-loss,_thm-cross-entropy-decomposition, and_thm-kl-divergence-nonnegative. The last is a seventh file beyond the six that #106 lists; it writesD_2the same way, and its proof uses the factorln 2, so the statement and that proof line now say the divergence uses base-2 logarithms.Edited lines gained links for the terms the term-link check found there: bits, binary digits, uniquely decodable code, loss and logarithms.
Checks run locally. Rendered
entropy.qmdandsource-coding.qmdto HTML: noH_2orD_2remains insource-coding.html, and the expanded math shows the macros' output. The only warning isdownlitandxml2missing from this machine. I looked at the expanded math in the built HTML, not a browser render. The term-link check passes through the push hook. 7 files, 21 lines changed, plus the term links.Not changed: the collision entropy fragments, which ids#100 converts to
\renyientropyf. The two PRs touch different files and can merge in either order.Generated by Claude Code