Repository navigation
preview: never build a fork PR for a private repository - #1655
Merged
Merged
Conversation
The build job runs on the caller's runner, which for a private repository is a lab runner or the cluster. Closes #1653. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9prTTV5VeAucmWBrnw
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Claude finished review — View run I fetched PR gha#1655 live. It is open, not a draft and not merged, and its head is The review stands: the earlier review of 2026-11-08T05:27:55Z also found it ready, and nothing in the diff has changed since. I did not run Two non-blocking suggestions from the first review still apply:
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "6b2b2b036c36a5e5ca9ad9a45b212cf5fdcc4384",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The build-job if guard in preview.yml composes correctly with the existing closed and label clauses, and the merge of main changed nothing in the PR's files.",
"holistic_assessment": "The change is minimal and in scope for gha#1653, adds no permissions or interface changes, and the wiring test pins both guard substrings."
}Reviewed commit: 6b2b2b0 Reviewed commit: 6b2b2b0 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
https://claude.ai/code/session_019xfc9prTTV5VeAucmWBrnw
Closes #1653.
The shared preview build job builds fork PRs on the caller's
runs-on. For a private repository that is a lab runner or the WWU cluster, so a fork PR would run its own code there. Each migrated caller had to carry its own guard, and the first six dropped it.The build job's
if:now requiresgithub.event.pull_request.head.repo.full_name == github.repository || !github.event.repository.private. A private repository never builds a fork PR; a public repository's fork PRs build on the caller's runner as before. Theclosed-event rule and the label rules are unchanged.test_a_private_repository_never_builds_a_fork_prinpreview/tests/test_action_wiring.pypins both clauses. It fails onmainand passes here (pytest preview/tests/test_action_wiring.py, 44 passed).Takes effect for callers once v3 slides. The callers' own guards can drop after that.
CI-only change.
Generated by Claude Code