Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the last piece of the code that is already deployed in old-dev (
hytale-proxy:519dcd3) ontomain.This is Santio's commit
da24bf9fromsantio/fix/rate-limit-disconnects, cherry-picked ontomainafter #1/#4 were squash-merged. Authorship is preserved; the tree is identical to that branch. The branch never had a PR, but the deployedserver.jarwas built from it.Verification: building
:proxy:buildfrom this branch produces a jar whoseac.evaclasses are bytecode-identical (javap diff empty) to theserver.jarcurrently onhytale-proxymaster. Without this commit, a rebuild frommainwould regress the deployed proxy.What it changes:
HytaleConnection.relay()/flushStreams(): forwarded packets are written without flushing and flushed onchannelReadCompleteof the peer, instead of per-packetwriteAndFlushdisconnect()falls back to closing the channel when the send future is null;close()usescloseApplicationConnectionFollow-up: rebuild and commit
server.jarinhytale-proxyfrom the resultingmaincommit so the shipped binary is traceable.https://claude.ai/code/session_01XtwsBnpBmDn6HWnHh1kNuL