Skip to content

Remove MIPS, PowerPC, and sparc64 support - #500

Open
laffer1 wants to merge 2 commits into
masterfrom
remove-legacy-architectures
Open

Remove MIPS, PowerPC, and sparc64 support#500
laffer1 wants to merge 2 commits into
masterfrom
remove-legacy-architectures

Conversation

@laffer1

@laffer1 laffer1 commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • remove native MIPS, PowerPC, and sparc64 source trees, release tooling, boot loaders, modules, and build wiring
  • retain amd64, i386, ARM, ARM64, and RISC-V native targets
  • retain optional LLVM/Clang/LLD foreign-target support for inspecting or producing non-native objects
  • regenerate src.conf(5) and document the supported-architecture change in UPDATING

Validation

  • make -V TARGETS universe reports: amd64 arm arm64 i386 riscv
  • make -n buildkernel KERNCONF=GENERIC completes successfully on amd64
  • the generated amd64 kernel plan contains no MIPS, PowerPC, or sparc64 source paths
  • modified shell scripts pass sh -n
  • git diff --check passes
  • src.conf(5) regenerated with tools/build/options/makeman

A make -n buildworld traversal reached lib/libpam/static_libpam before stopping because dry-run mode did not create the prerequisite pam_xdg archive. Before that, it exposed one malformed libc conditional introduced during removal; that conditional was fixed and the traversal then passed libc and continued through the world tree.

The repository C sanity wrapper could not complete because clang-format19 rejects the existing .clang-format configuration for rtld.h and whole-file formatting creates large unrelated churn in legacy sources. Manual clang-tidy, cppcheck, and Splint attempts were also limited by missing per-component include/configuration context and existing diagnostics. No analyzer diagnostic was traced to the removed branches.

AI contribution checklist

  • Human maintainer has manually reviewed every AI-assisted C/C++ change
  • No proprietary or copyleft code was introduced
  • Assembly sources were removed manually by the human maintainer
  • Final maintainer style review completed

@laffer1
Remove legacy architecture support
6338fe3 
Remove native MIPS, PowerPC, and sparc64 source trees and build wiring. Retain amd64, i386, ARM, ARM64, and RISC-V as supported native architectures.

Portions obtained from: FreeBSD

AI-Assisted-by: OpenAI Codex (GPT-5)
Signed-off-by: Lucas Holt <luke@foolishgames.com>
@laffer1
UPDATING: document legacy architecture removal
10db70c 
AI-Assisted-by: OpenAI Codex (GPT-5)
Signed-off-by: Lucas Holt <luke@foolishgames.com>
Copilot AI lite review requested due to automatic review settings September 4, 2026 15:32
sourcery-ai[bot]
sourcery-ai Bot reviewed Sep 4, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 300 files, and this pull request has 1483

@github-actions

github-actions Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Claude finished @laffer1's task in 2m 37s —— View job

Claude finished the review

Todo list

  • Gather context (read diff, changed files)
  • Understand the request (code review per custom instructions)
  • Review for correctness bugs, malloc/free symmetry, bounds checking
  • Review for style(9) compliance
  • Check for assembly/contrib/mksh changes (AI review prohibited) — none found; all .S/assembly changes in this PR are pure deletions, and the PR body confirms the human maintainer removed them manually
  • Post final review

Summary

This PR is almost entirely deletions (removing MIPS/PowerPC/sparc64 source trees), so I focused review effort on the ~120 files that were actually modified rather than deleted, since that's where logic/whitespace mistakes are most likely to hide. I did not find any correctness bugs, malloc/free asymmetries, or bounds-checking issues in the surviving code paths — the #ifdef/#if defined(__mips__|__powerpc__|...) removals are consistently clean and the remaining logic collapses correctly to the amd64/i386/arm/arm64/riscv behavior that was already the default for those architectures.

Three minor style(9) nits worth a follow-up cleanup (none blocking):

  1. lib/libkvm/kvm_private.c:149-150 — removing the powerpc comment block also removed the blank line separating _kvm_is_minidump() from _kvm_read_core_phdrs(). style(9) requires a blank line between function definitions.

    	return (0);
}
int
_kvm_read_core_phdrs(kvm_t *kd, size_t *phnump, GElf_Phdr **phdrp)

  2. Stray double-blank-lines left behind by #if/#endif removal in lib/libc/gen/elf_utils.c:56-57 and libexec/rtld-elf/rtld.c:554-555.

  3. stand/common/modinfo.h:10 — md_load64() is declared but its only definition (stand/common/metadata.c, guarded by #if defined(__mips__) || defined(__powerpc__)) was removed in this PR, and no caller remains anywhere in the tree. The now-dead prototype could be dropped for consistency with the rest of the cleanup.

Fix these →

No security issues, and no assembly or contrib/mksh content was AI-authored in this diff.
· branch remove-legacy-architectures

Copilot AI reviewed Sep 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The change set is very large and touches core build system + kernel/userland components across many subsystems, so it warrants final human review despite only minor localized issues found.

Pull request overview

This PR removes native support for the MIPS, PowerPC, and sparc64 architectures across the MidnightBSD source tree, including their kernel/userland sources, boot tooling, build wiring, and related documentation, while retaining native amd64/i386/arm/arm64/riscv targets and keeping optional LLVM cross-target capabilities.

Changes:

  • Removed MIPS/PowerPC/sparc64 architecture-specific source trees, build targets, and release/boot image tooling.
  • Simplified build and test conditionals that previously special-cased MIPS/PowerPC (and sparc64 in some docs/comments).
  • Updated documentation and release notes (UPDATING + various manpages/READMEs) to reflect the supported-architecture set.
File summaries
File Description
usr.sbin/nvram/Makefile Removed PowerPC-specific nvram utility build/install.
usr.sbin/Makefile.powerpc Removed PowerPC-only usr.sbin subdir wiring.
usr.sbin/Makefile.mips Removed MIPS-only usr.sbin subdir wiring.
usr.sbin/kldxref/Makefile Dropped MIPS/PowerPC ELF format handlers from kldxref.
usr.sbin/config/config.5 Updated documented architecture list to remove mips/powerpc.
usr.sbin/bsdinstall/scripts/bootconfig Removed PowerPC-specific installer boot configuration path.
usr.bin/uname/uname.1 Removed PowerPC-specific example text.
usr.bin/truss/syscalls.c Removed MIPS/PowerPC-specific syscall decoding/ABI handling notes/paths.
usr.bin/Makefile.powerpc Removed PowerPC-only usr.bin subdir wiring.
usr.bin/gh-bc/Makefile Simplified LTO gating after dropping MIPS/PowerPC.
usr.bin/getconf/getconf.1 Updated platform notes to remove PowerPC/sparc64 references.
usr.bin/gcore/Makefile Removed PowerPC-specific conditional source inclusion.
usr.bin/clang/Makefile.inc Removed MIPS-only compiler flags.
UPDATING Documented removal of native MIPS/PowerPC/sparc64 support and remaining supported architectures.
tools/tools/nanobsd/embedded/README Removed MIPS/PowerPC NanoBSD QEMU image references.
tools/tools/nanobsd/embedded/qemu-powerpc64.cfg Removed PowerPC64 NanoBSD embedded config.
tools/tools/nanobsd/embedded/qemu-mips64.cfg Removed MIPS64 NanoBSD embedded config.
tools/tools/nanobsd/embedded/qemu-mips.cfg Removed MIPS NanoBSD embedded config.
tools/boot/universe.sh Removed MIPS/PowerPC stand build loops and updated supported-arch comment.
tools/boot/rootgen.sh Removed MIPS/PowerPC image-generation notes and loops.
tests/sys/vm/Makefile Simplified MAP_32BIT test gating after removing MIPS/PowerPC.
tests/sys/kern/Makefile Simplified physmem test gating after removing MIPS/PowerPC.
tests/sys/fs/Makefile Removed MIPS/clang-specific fusefs test exclusion.
targets/pseudo/userland/misc/Makefile.depend Removed PowerPC userland pseudo-target dirdeps.
targets/pseudo/userland/Makefile.depend Removed MIPS/PowerPC pseudo-userland dirdeps.
targets/pseudo/userland/lib/Makefile.depend Removed PowerPC-only stand/libsa32 dirdep enablement.
sys/README.md Removed PowerPC entry from kernel source roadmap.
sys/powerpc/ps3/ps3-hv-header.awk Removed PowerPC PS3 tool script.
sys/powerpc/mambo/mambocall.S Removed PowerPC Mambo assembly support file.
sys/powerpc/mambo/mambocall.h Removed PowerPC Mambo header.
sys/powerpc/include/stdarg.h Removed PowerPC machine stdarg header.
sys/powerpc/include/stack.h Removed PowerPC machine stack header.
sys/powerpc/include/setjmp.h Removed PowerPC machine setjmp header.
sys/powerpc/include/reloc.h Removed PowerPC relocation header.
sys/powerpc/include/procctl.h Removed PowerPC procctl header stub.
sys/powerpc/include/machdep.h Removed PowerPC machdep header.
sys/powerpc/include/exec.h Removed PowerPC exec header.
sys/powerpc/include/efi.h Removed PowerPC EFI header stub.
sys/powerpc/include/clock.h Removed PowerPC clock header.
sys/powerpc/include/bus_dma.h Removed PowerPC bus_dma header.
sys/powerpc/conf/LINT64LE Removed PowerPC64LE LINT kernel config.
sys/powerpc/conf/LINT64 Removed PowerPC64 LINT kernel config.
sys/powerpc/conf/LINT Removed PowerPC LINT kernel config.
sys/powerpc/conf/dpaa/config.dpaa Removed PowerPC DPAA kernel config fragment.
sys/powerpc/conf/DEFAULTS Removed PowerPC DEFAULTS kernel config.
sys/powerpc/aim/locore.S Removed PowerPC AIM locore include/entry glue.
sys/modules/zfs/Makefile Removed PowerPC-specific 32-bit/atomic source conditionals.
sys/modules/usb/Makefile Removed MIPS-only module selection and simplified firmware module list.
sys/modules/uart/Makefile Removed PowerPC from OFW interface gating.
sys/modules/sound/driver/Makefile Removed PowerPC-only sound driver subdirs.
sys/modules/sound/driver/davbus/Makefile Removed PowerPC-only davbus module build file.
sys/modules/sound/driver/ai2s/Makefile Removed PowerPC-only ai2s module build file.
sys/modules/scc/Makefile Removed PowerPC-only SCC backend sources selection.
sys/modules/powermac_nvram/Makefile Removed PowerPC-only powermac_nvram module build file.
sys/modules/opal_nvram/Makefile Removed PowerPC-only opal_nvram module build file.
sys/modules/netfpga10g/nf10bmac/Makefile Removed MIPS-only NetFPGA module build file.
sys/modules/netfpga10g/Makefile Removed MIPS-only NetFPGA subdir build file.
sys/modules/ipmi/Makefile Removed PowerPC64 OPAL IPMI glue source inclusion.
sys/modules/i2c/iicbb/Makefile Removed MIPS/PowerPC from OFW interface gating.
sys/modules/hwpmc/Makefile Removed PowerPC hwpmc sources.
sys/modules/hwpmc_mips74k/Makefile Removed MIPS74k hwpmc module build file.
sys/modules/hwpmc_mips24k/Makefile Removed MIPS24k hwpmc module build file.
sys/modules/gem/Makefile Removed PowerPC-only OFW interface selection.
sys/modules/dtrace/Makefile Removed MIPS/PowerPC dtrace module selection and systrace_freebsd32 gating.
sys/modules/dtrace/fasttrap/Makefile Removed PowerPC-specific include/path selection.
sys/modules/cpufreq/Makefile Removed PowerPC-specific cpufreq sources.
sys/modules/cas/Makefile Removed PowerPC-only OFW interface selection.
sys/modules/ar71xx/Makefile Removed MIPS-only ar71xx module subdir build file.
sys/modules/agp/Makefile Removed PowerPC-only AGP source.
sys/modules/aacraid/Makefile Removed PowerPC-only endian helper source.
sys/mips/nlm/std.xlp Removed MIPS NLM kernel std fragment.
sys/mips/mips/ptrace_machdep.c Removed MIPS ptrace machdep placeholder file.
sys/mips/malta/std.malta Removed MIPS Malta std fragment.
sys/mips/malta/gtvar.h Removed MIPS Malta GT header.
sys/mips/malta/gt_pci_bus_space.h Removed MIPS Malta GT PCI bus space header.
sys/mips/malta/files.malta Removed MIPS Malta files list.
sys/mips/ingenic/jz4780_pinctrl.h Removed MIPS Ingenic pinctrl header stub.
sys/mips/ingenic/jz4780_clock.h Removed MIPS Ingenic clock header.
sys/mips/ingenic/files.x1000 Removed MIPS Ingenic X1000 files list.
sys/mips/include/stdarg.h Removed MIPS machine stdarg header.
sys/mips/include/procctl.h Removed MIPS procctl header stub.
sys/mips/include/metadata.h Removed MIPS metadata header.
sys/mips/include/ieeefp.h Removed MIPS legacy ieeefp header.
sys/mips/include/fpu.h Removed MIPS FPU header stub.
sys/mips/include/efi.h Removed MIPS EFI header stub.
sys/mips/include/clock.h Removed MIPS clock header.
sys/mips/include/bus_dma.h Removed MIPS bus_dma header.
sys/mips/conf/XLPN32 Removed MIPS XLPN32 kernel config.
sys/mips/conf/XLP64 Removed MIPS XLP64 kernel config.
sys/mips/conf/XLP.hints Removed MIPS XLP device hints.
sys/mips/conf/X1000.hints Removed MIPS X1000 device hints.
sys/mips/conf/RSPRO_STANDALONE Removed MIPS Routerstation Pro standalone config.
sys/mips/conf/RSPRO_MFS Removed MIPS Routerstation Pro MFS config.
sys/mips/conf/RSPRO Removed MIPS Routerstation Pro config.
sys/mips/conf/ROUTERSTATION_MFS Removed MIPS Routerstation MFS config.
sys/mips/conf/ROUTERSTATION Removed MIPS Routerstation config.
sys/mips/conf/PB47 Removed MIPS PB47 config.
sys/mips/conf/OCTEON1.hints Removed MIPS OCTEON1 hints.
sys/mips/conf/MALTAEL Removed MIPS MALTAEL config.
sys/mips/conf/MALTA64EL Removed MIPS MALTA64EL config.
sys/mips/conf/MALTA64 Removed MIPS MALTA64 config.
sys/mips/conf/MALTA.hints Removed MIPS MALTA hints.
sys/mips/conf/MALTA Removed MIPS MALTA config.
sys/mips/conf/JZ4780.hints Removed MIPS JZ4780 hints.
sys/mips/conf/ENH200 Removed MIPS ENH200 config.
sys/mips/conf/DEFAULTS Removed MIPS DEFAULTS kernel config.
sys/mips/conf/CI20 Removed MIPS CI20 config.
sys/mips/conf/CANNA Removed MIPS CANNA config.
sys/mips/conf/BERI_SOCKIT Removed MIPS BERI SoCKit config.
sys/mips/conf/BERI_SIM_VIRTIO Removed MIPS BERI simulation virtio config.
sys/mips/conf/BERI_SIM_SDROOT Removed MIPS BERI simulation SD root config.
sys/mips/conf/BERI_SIM_MDROOT Removed MIPS BERI simulation MD root config.
sys/mips/conf/BERI_SIM_BASE Removed MIPS BERI simulation base config.
sys/mips/conf/BERI_NETFPGA_MDROOT Removed MIPS BERI NetFPGA MD root config.
sys/mips/conf/BERI_DE4.hints Removed MIPS BERI DE4 hints.
sys/mips/conf/BERI_DE4_SDROOT Removed MIPS BERI DE4 SD root config.
sys/mips/conf/BERI_DE4_MDROOT Removed MIPS BERI DE4 MD root config.
sys/mips/conf/BCM.hints Removed MIPS Broadcom hints.
sys/mips/conf/AR5315_BASE.hints Removed MIPS AR5315 base hints.
sys/mips/conf/AR5312_BASE.hints Removed MIPS AR5312 base hints.
sys/mips/conf/AP96 Removed MIPS AP96 config.
sys/mips/conf/AP94.hints Removed MIPS AP94 hints.
sys/mips/conf/AP94 Removed MIPS AP94 config.
sys/mips/conf/AP93 Removed MIPS AP93 config.
sys/mips/cavium/std.octeon1 Removed MIPS Cavium OCTEON1 std fragment.
sys/mips/broadcom/std.broadcom Removed MIPS Broadcom std fragment.
sys/mips/beri/std.beri Removed MIPS BERI std fragment.
sys/mips/atheros/uart_dev_ar933x.h Removed MIPS Atheros UART device header.
sys/mips/atheros/std.ar71xx Removed MIPS Atheros ar71xx std fragment.
sys/mips/atheros/qca955x_chip.h Removed MIPS Atheros qca955x chip header.
sys/mips/atheros/qca953x_chip.h Removed MIPS Atheros qca953x chip header.
sys/mips/atheros/ar934x_chip.h Removed MIPS Atheros ar934x chip header.
sys/mips/atheros/ar933x_chip.h Removed MIPS Atheros ar933x chip header.
sys/mips/atheros/ar91xx_chip.h Removed MIPS Atheros ar91xx chip header.
sys/mips/atheros/ar724x_chip.h Removed MIPS Atheros ar724x chip header.
sys/mips/atheros/ar531x/files.ar5315 Removed MIPS Atheros ar5315 files list.
sys/mips/atheros/ar531x/ar5315_chip.h Removed MIPS Atheros ar5315 chip header.
sys/mips/atheros/ar531x/ar5312_chip.h Removed MIPS Atheros ar5312 chip header.
sys/Makefile Removed mips/powerpc from ALL_ARCH cscope directory list.
sys/kern/vfs_cache.c Generalized ILP32 alignment comment after removing mips-specific note.
sys/kern/vfs_bio.c Removed mips-specific buffer pager default and updated low-memory comment.
sys/kern/uipc_mbuf.c Removed PowerPC BOOKE-specific mbuf layout assertion.
sys/dts/powerpc/Makefile Removed PowerPC DTS makefile.
sys/dts/mips/Makefile Removed MIPS DTS makefile.
sys/dts/mips/fbsd-rt3883.dtsi Removed MIPS DTS include file.
sys/dts/mips/fbsd-mt7628an.dtsi Removed MIPS DTS include file.
sys/dts/mips/fbsd-mt7620a.dtsi Removed MIPS DTS include file.
sys/dts/Makefile Removed mips/powerpc DTS subdirs.
sys/dev/usb/usb_freebsd.h Removed MIPS/PowerPC from USB host alignment selection.
sys/dev/evdev/evdev.c Removed PowerPC-specific evdev recipient mask special-casing.
sys/conf/options.powerpc Removed PowerPC kernel option list.
sys/conf/kern.opts.mk Removed MIPS/PowerPC broken-options special cases; updated EFI broken-options gating.
sys/conf/config.mk Removed MIPS-only opt_global.h define suppression and removed PowerPC KERN_OPTS.
sys/cddl/dev/profile/profile.c Removed MIPS/PowerPC-specific profiling frame hacks.
sys/cddl/dev/fbt/powerpc/fbt_isa.h Removed PowerPC FBT ISA header.
sys/cddl/dev/fbt/mips/fbt_isa.h Removed MIPS FBT ISA header.
sys/cddl/contrib/opensolaris/uts/mips/dtrace/fasttrap_isa.c Removed MIPS fasttrap placeholder source.
stand/usb/Makefile Removed MIPS-only ubldr compilation flag.
stand/uboot/glue.h Removed MIPS-specific reduced API signature search range.
stand/uboot/arch/powerpc/Makefile.inc Removed PowerPC uboot loader arch build wiring.
stand/uboot/arch/mips/Makefile.inc Removed MIPS uboot loader arch build wiring and artifacts rules.
stand/powerpc/ofw/version Removed PowerPC OFW version file.
stand/powerpc/Makefile.inc Removed PowerPC stand include glue.
stand/powerpc/Makefile Removed PowerPC stand subtree build file.
stand/powerpc/boot1.chrp/Makefile.hfs Removed PowerPC HFS boot1 metadata file.
stand/powerpc/boot1.chrp/bootinfo.txt Removed PowerPC CHRP boot metadata.
stand/loader.mk Removed MIPS/PowerPC loader source selection branches.
stand/libsa/zalloc_defs.h Removed MIPS/PowerPC from MALLOCALIGN selection.
stand/libsa/Makefile Removed PowerPC-only syncicache source inclusion.
stand/kboot/hostfs.c Updated hostfs comment to drop PowerPC interface note.
stand/kboot/host_syscall.h Updated constants comment to drop PowerPC mention.
stand/kboot/arch/powerpc64/syscall_nr.h Removed PowerPC64 kboot syscall table.
stand/kboot/arch/powerpc64/stat_arch.h Removed PowerPC64 kboot stat ABI header.
stand/kboot/arch/powerpc64/start_arch.h Removed PowerPC64 kboot startup shim.
stand/kboot/arch/powerpc64/Makefile.inc Removed PowerPC64 kboot arch build wiring.
stand/ficl/loader.c Removed PowerPC ficl environment settings.
stand/ficl.mk Removed mips64 ficl CPUARCH mapping.
stand/common/metadata.c Removed MIPS/PowerPC loader metadata special-casing and md_load64.
share/mk/sys.mk Removed mips/powerpc from MACHINE_CPUARCH normalization map.
share/mk/sys.dependfile.mk Updated default machine list for dependfile preferences.
share/mk/local.meta.sys.mk Removed mips/powerpc target-arches and updated ALL_MACHINE_LIST.
share/mk/bsd.prog.mk Removed MIPS64 clang TLS-model workaround.
share/mk/bsd.opts.mk Removed mips/powerpc from default “NO PIE” architecture list.
share/mk/bsd.lib.mk Removed MIPS64 clang TLS-model workaround for static objects.
share/mk/bsd.endian.mk Removed mips/powerpc endianness branches; simplified for remaining architectures.
share/man/man4/smp.4 Updated SMP documentation to remove PowerPC/MIPS/sparc64 references.
share/man/man4/man4.powerpc/Makefile.depend Removed PowerPC man4 subdir dependfile.
share/man/man4/man4.powerpc/Makefile Removed PowerPC-only man4 pages build file.
share/man/man4/Makefile Removed MIPS/PowerPC-only manpage conditionals.
sbin/Makefile.powerpc64 Removed PowerPC64-only sbin subdirs.
sbin/Makefile.mips Removed MIPS-only sbin subdirs.
sbin/devd/Makefile Removed PowerPC-only devd configuration file inclusion.
release/tools/vmimage.subr Removed PowerPC release VM image scheme handling.
release/powerpc/powerpcspe.conf Removed PowerPCspe release configuration.
release/powerpc/powerpc64le.conf Removed PowerPC64LE release configuration.
release/powerpc/powerpc64.conf Removed PowerPC64 release configuration.
release/powerpc/powerpc.conf Removed PowerPC release configuration.
release/powerpc/boot.tbxi Removed PowerPC CHRP boot metadata used in release artifacts.
Makefile.libcompat Updated compat-lib description after removing MIPS/PowerPC compat builds.
libexec/rtld-elf/rtld.h Removed MIPS/PowerPC-specific Obj_Entry fields.
libexec/rtld-elf/rtld-libc/Makefile.inc Removed PowerPC arch special-casing for selecting libc objects.
libexec/rtld-elf/powerpc64/Makefile.inc Removed PowerPC64 rtld entry definition.
libexec/rtld-elf/mips/Makefile.inc Removed MIPS rtld CFLAGS special-casing.
libexec/rtld-elf/Makefile Simplified rtld arch selection by removing PowerPC64LE remapping.
libexec/rc/rc.d/ldconfig Removed mips64/powerpc64 from 32-bit libdir ldconfig handling.
lib/msun/powerpc/Symbol.map Removed PowerPC msun symbol map.
lib/msun/powerpc/Makefile.inc Removed PowerPC msun build include.
lib/msun/mips/Symbol.map Removed MIPS msun symbol map.
lib/msun/mips/Makefile.inc Removed MIPS msun build include.
lib/Makefile Removed PowerPC from libclang_rt gating and enabled libomp unconditionally.
lib/libthr/arch/powerpc/Makefile.inc Removed PowerPC libthr assembly source inclusion.
lib/libsqlite3/Makefile Removed PowerPC64LE endianness override.
lib/libpmcstat/libpmcstat_image.c Removed PowerPC kernel base-address relocation hack.
lib/libpmc/pmu-events/arch/powerpc/power9/floating-point.json Removed PowerPC PMU events JSON.
lib/libpmc/pmu-events/arch/powerpc/power8/floating-point.json Removed PowerPC PMU events JSON.
lib/libpmc/pmu-events/arch/powerpc/mapfile.csv Removed PowerPC PMU events mapfile.
lib/libpmc/pmc.3 Removed MIPS PMC manpage cross-references.
lib/libpmc/Makefile Removed PowerPC and MIPS PMC support wiring.
lib/libkvm/Makefile Removed MIPS/PowerPC kvm backends and minidump support sources.
lib/libkvm/kvm_private.c Removed PowerPC-specific minidump/core header commentary.
lib/libgcc_s/Makefile Simplified long double source inclusion after dropping MIPS/PowerPC.
lib/libgcc_eh/Makefile.inc Removed PowerPC from unwind frame API support gating.
lib/libdl/Makefile Simplified rtld arch selection by removing PowerPC64LE remapping.
lib/libcompiler_rt/Makefile.inc Removed PowerPC/mips handling and paths from compiler-rt builtins selection.
lib/libclang_rt/xray/Makefile Removed PowerPC64LE xray sources.
lib/libclang_rt/Makefile Removed PowerPC sanitizer subdir selection.
lib/libclang_rt/compiler-rt-vars.mk Removed mipsn32→mips64 CRTARCH remapping.
lib/libc/sys/Makefile.inc Removed PowerPC from NOTE_GNU_STACK gating.
lib/libc/powerpcspe/sys/Makefile.inc Removed PowerPCspe libc sys makefile include.
lib/libc/powerpcspe/Makefile.inc Removed PowerPCspe libc arch makefile include.
lib/libc/powerpcspe/gen/Makefile.inc Removed PowerPCspe libc gen makefile include.
lib/libc/powerpcspe/gen/fabs.S Removed PowerPCspe fabs implementation.
lib/libc/powerpc64/sys/Makefile.inc Removed PowerPC64 libc sys sources.
lib/libc/powerpc64/Symbol.map Removed PowerPC64 libc symbol map.
lib/libc/powerpc64/string/strncpy.c Removed PowerPC64 string wrapper source.
lib/libc/powerpc64/string/strcpy.c Removed PowerPC64 string wrapper source.
lib/libc/powerpc64/string/memmove.S Removed PowerPC64 memmove assembly wrapper.
lib/libc/powerpc64/string/memmove_vsx.S Removed PowerPC64 VSX memmove wrapper.
lib/libc/powerpc64/string/memmove_resolver.c Removed PowerPC64 memmove resolver wrapper.
lib/libc/powerpc64/string/memcpy_resolver.c Removed PowerPC64 memcpy resolver wrapper.
lib/libc/powerpc64/string/Makefile.inc Removed PowerPC64 string arch makefile.
lib/libc/powerpc64/Makefile.inc Removed PowerPC64 libc arch makefile.
lib/libc/powerpc64/gen/Makefile.inc Removed PowerPC64 libc gen sources.
lib/libc/powerpc64/gen/infinity.c Removed PowerPC64 infinity/NaN constants source.
lib/libc/powerpc64/gen/fabs.S Removed PowerPC64 fabs assembly implementation.
lib/libc/powerpc64/gen/_set_tp.c Removed PowerPC64 TLS TP setter implementation.
lib/libc/powerpc64/gd_qnan.h Removed PowerPC64 gdtoa QNaN header.
lib/libc/powerpc64/arith.h Removed PowerPC64 gdtoa arith header.
lib/libc/powerpc/sys/Makefile.inc Removed PowerPC libc sys sources.
lib/libc/powerpc/Symbol.map Removed PowerPC libc symbol map.
lib/libc/powerpc/Makefile.inc Removed PowerPC libc arch makefile.
lib/libc/powerpc/gen/Makefile.inc Removed PowerPC libc gen makefile include.
lib/libc/powerpc/gen/Makefile.common Removed PowerPC libc gen common makefile.
lib/libc/powerpc/gen/infinity.c Removed PowerPC infinity/NaN constants source.
lib/libc/powerpc/gen/fabs.S Removed PowerPC fabs assembly implementation.
lib/libc/powerpc/gen/eabi.S Removed PowerPC EABI stub.
lib/libc/powerpc/gen/_set_tp.c Removed PowerPC TLS TP setter implementation.
lib/libc/powerpc/gd_qnan.h Removed PowerPC gdtoa QNaN header.
lib/libc/powerpc/arith.h Removed PowerPC gdtoa arith header.
lib/libc/mips/sys/Makefile.inc Removed MIPS libc sys makefile include.
lib/libc/mips/Symbol.map Removed MIPS libc symbol map.
lib/libc/mips/string/memmove.S Removed MIPS memmove assembly wrapper.
lib/libc/mips/string/memcpy.S Removed MIPS memcpy assembly wrapper.
lib/libc/mips/string/Makefile.inc Removed MIPS string arch makefile.
lib/libc/mips/net/Makefile.inc Removed MIPS net arch makefile include.
lib/libc/mips/Makefile.inc Removed MIPS libc arch makefile.
lib/libc/mips/gen/Makefile.inc Removed MIPS libc gen sources makefile.
lib/libc/mips/gen/infinity.c Removed MIPS infinity/NaN constants source.
lib/libc/mips/gen/hardfloat/fpsetsticky.c Removed MIPS hardfloat helper.
lib/libc/mips/gen/hardfloat/fpsetround.c Removed MIPS hardfloat helper.
lib/libc/mips/gen/hardfloat/fpsetmask.c Removed MIPS hardfloat helper.
lib/libc/mips/gen/hardfloat/fpgetsticky.c Removed MIPS hardfloat helper.
lib/libc/mips/gen/hardfloat/fpgetround.c Removed MIPS hardfloat helper.
lib/libc/mips/gen/hardfloat/fpgetmask.c Removed MIPS hardfloat helper.
lib/libc/mips/gen/flt_rounds.c Removed MIPS __flt_rounds implementation.
lib/libc/mips/gen/_set_tp.c Removed MIPS TLS TP setter implementation.
lib/libc/mips/arith.h Removed MIPS gdtoa arith header.
lib/libc/gen/tls.c Updated TLS variant comment to remove MIPS/PowerPC mention.
lib/libc/gen/elf_utils.c Removed PowerPC64 ELFv1 function-descriptor exception path.
lib/libc/csu/powerpcspe/Makefile.inc Removed PowerPCspe csu makefile include.
lib/libc/csu/powerpc64/Makefile.inc Removed PowerPC64 csu makefile include.
lib/libc/csu/powerpc/Makefile.inc Removed PowerPC csu makefile include.
lib/libc/csu/mips/Makefile.inc Removed MIPS csu makefile include.
lib/libarchive/Makefile Removed PowerPC from NO_WCAST_ALIGN conditional.
lib/csu/powerpc64/Makefile.depend Removed PowerPC64 csu dependfile.
lib/csu/powerpc64/Makefile Removed PowerPC64 csu build file.
lib/csu/powerpc64/crt.h Removed PowerPC64 crt.h.
lib/csu/powerpc/Makefile.depend Removed PowerPC csu dependfile.
lib/csu/powerpc/Makefile Removed PowerPC csu build file.
lib/csu/powerpc/crt.h Removed PowerPC crt.h.
lib/csu/mips/Makefile.depend Removed MIPS csu dependfile.
lib/csu/mips/Makefile Removed MIPS csu build file.
lib/csu/mips/crtn.S Removed MIPS crtn.S.
lib/csu/Makefile Simplified csu subdir selection by removing PowerPC64LE remapping.
lib/clang/libllvm/Makefile Removed PowerPC-specific PIC workaround.
lib/clang/libclang/Makefile Removed PowerPC-specific PIC workaround.
include/Makefile Removed PowerPC-only header install subdir for powermac_nvram.
etc/mtree/BSD.usr.dist Removed PowerPC man subtree directories from mtree spec.
cddl/usr.sbin/zfsd/zfsd_event.cc Removed sparc64 flush macro workaround comment/undef.
cddl/usr.sbin/zfsd/vdev.cc Removed sparc64 flush macro workaround comment/undef.
cddl/usr.sbin/Makefile Removed MIPS/PowerPC dtrace tool subdir enablement.
cddl/lib/libzpool/Makefile Removed PowerPC PIC workaround and MIPS/clang-specific workaround flags.
cddl/lib/libdtrace/Makefile Removed MIPS/PowerPC include paths and source directories for libdtrace.
Review details
  • Files reviewed: 227/1483 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sys/modules/uart/Makefile
@@ -8,7 +8,7 @@ uart_cpu_acpi=uart_cpu_acpi.c
.endif

.if ${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_CPUARCH} == "arm" || \
${MACHINE_CPUARCH} == "powerpc" || ${MACHINE_CPUARCH} == "riscv"
${MACHINE_CPUARCH} == "riscv"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laffer1