Fix formula for output buffer size for FSCTL_GET_NTFS_FILE_RECORD - #2187
Open
Max Bulatoff (bulmax) wants to merge 1 commit into
Open
Fix formula for output buffer size for FSCTL_GET_NTFS_FILE_RECORD#2187Max Bulatoff (bulmax) wants to merge 1 commit into
Max Bulatoff (bulmax) wants to merge 1 commit into
Conversation
Due to alignment, sizeof(NTFS_FILE_RECORD_OUTPUT_BUFFER)=16, but output buffer's correct size should be 12+BytesPerFileRecordSegment, not 15+BytesPerFileRecordSegment.
John Kennedy (GrantMeStrength)
approved these changes
Jul 17, 2026
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
Contributor
There was a problem hiding this comment.
LGTM — accurate technical correction. Approved.
Contributor
|
Copilot /review |
John Kennedy (GrantMeStrength)
approved these changes
Jul 17, 2026
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
Contributor
There was a problem hiding this comment.
Reviewed ✅ — Documentation improvement looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to alignment, sizeof(NTFS_FILE_RECORD_OUTPUT_BUFFER)=16, but output buffer's correct size should be 12+BytesPerFileRecordSegment, not 15+BytesPerFileRecordSegment.