Add Twig templates for be_ace_mm and be_tinyMCE_mm - #1594
Merged
Conversation
Both legacy .html5 templates now have a Twig counterpart, so the Twig-preferred loader picks them up automatically. be_ace_mm mirrors the original inline-script approach (creates the ACE editor div, theme detection, maxLines/minLines from rows, turbo:render rebinding). be_tinyMCE_mm extends core's own @Contao/be_tinyMCE.html.twig and overrides the "custom" block to add max_height from rows, matching the previous PHP template inheritance. Verified with Playwright against the mm_employees devstack: ACE editor renders with correct maxLines/minLines, TinyMCE renders with the max_height override, no JS errors in either case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018K6QN9FHjYVFbdRF7PP5fi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
be_ace_mm.html.twig, mirroring the legacy.html5inline script (editor div creation, theme detection,maxLines/minLinesfromrows, turbo:render rebinding)be_tinyMCE_mm.html.twig, extending core's own@Contao/be_tinyMCE.html.twigand overriding thecustomblock to addmax_heightfromrows, matching the previous PHP template inheritanceTest plan
mm_employees,Langtextattribute): ACE editor renders with correctmaxLines/minLines, no JS errorsmax_heightoverride, no JS errorstinyMCEbehavior correctly whenrteis unset/default