Quote the column name in MetaModel::saveSimpleColumn()'s UPDATE statement - #1590
Merged
Conversation
…ment Same pattern as BaseSimple::setDataFor(): "SET <column> = ..." built with the bare, unquoted column name - breaks for any column whose name happens to be a SQL reserved word. Currently only called with fixed literals (vargroup, pid, sorting, tstamp), none of which are reserved words, but the method is protected and can be called with arbitrary column names by subclasses. Quoted via Connection::quoteIdentifier().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same pattern as BaseSimple::setDataFor(): "SET = ..." built with the bare, unquoted column name - breaks for any column whose name happens to be a SQL reserved word. Currently only called with fixed literals (vargroup, pid, sorting, tstamp), none of which are reserved words, but the method is protected and can be called with arbitrary column names by subclasses. Quoted via
Connection::quoteIdentifier().