Repository navigation
Conversation
NaN passed the number check and still hashed. Number.isInteger rejects it before the authorization is signed or recovered.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateEIP7702Authorizationtreated anynumberbelow2 ** 256as a chain id, and anynumberbelow2 ** 64as a nonce.NaNfails both comparisons, so it passed.hashEIP7702Authorization([NaN, address, 0])returneddb86e3cd1a31bc187733ee8b8a707715572ba541f4774be4f7cbba44ab45d453. ANaNnonce hashed the same as nonce0.Number.isIntegernow rejectsNaNand fractional values. Integer chain ids and nonces still sign and recover.Test plan
should throw if chainId is NaNandshould throw if nonce is NaNdid not throw on mainnpx jest src/sign-eip7702-authorization.test.ts(38 tests OK)Made with Cursor