Repository navigation
fix: mustBeMetaMask should not detect brave as MetaMask - #87
Open
gomesalexandre wants to merge 1 commit into
Open
gomesalexandre wants to merge 1 commit into
gomesalexandre wants to merge 1 commit into
Conversation
oelrefaey5
approved these changes
Mar 17, 2024
Brave's built-in wallet sets isMetaMask: true for compatibility, so mustBeMetaMask: true false-positives on Brave. Guard on !isBraveWallet too. Rebased onto the current src/ layout (split into detect-ethereum-provider.ts/metamask-ethereum-provider.ts since this PR was opened).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brave Wallet's
window.ethereumsetsisMetaMaskto true, hence using themustBeMetaMaskoption here will falsely detect Brave as MM, see:https://github.com/brave/brave-core/blob/ae4c9dab752c588fc7b5921863f862777a19589d/components/brave_wallet/renderer/js_ethereum_provider.cc#L254-L256
This is a non-standard behavior of Brave as opposed to most MetaMask impersonators setting
isMetaMaskto false, hence requires explicit handling. Thankfully, aisBraveWalletproperty is also exposed (brave/brave-core#12794), which we can check for to guard against wrongly detecting Brave as MM.Note
Low Risk
Narrow change to provider detection when mustBeMetaMask is true; default detection behavior is unchanged for non-Brave providers.
Overview
When
mustBeMetaMaskis enabled, detection no longer treats Brave Wallet as MetaMask. Brave’s injected provider setsisMetaMask: true, so the previous check could return Brave as a match; the resolver now also requires!ethereum.isBraveWallet.The
MetaMaskEthereumProvidertype gains optionalisBraveWallet, and a test asserts thatmustBeMetaMask: trueresolves tonullwhen the mock provider has both flags set.Reviewed by Cursor Bugbot for commit b990296. Bugbot is set up for automated code reviews on this repo. Configure here.