Repository navigation
fix: preserve TUI transcript follow during reflow - #331
Merged
Merged
Conversation
6 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the session TUI treating a negative
scrollTopadjustment caused by viewport resize or a tall Shell-output reflow as a manual scroll-up. That detached bottom-follow mode and made navigation appear stuck or jumpy on short terminals.The session now passes its current bottom state into the movement classifier. While follow mode is active, layout changes at the bottom no longer detach follow; an actual manual scroll-up still does. The smoke harness accepts bounded terminal dimensions so the PTY path can be exercised at 80x24.
Type
Verification
bun test test/cli/tui/prompt-working-start.test.ts— 110 passed, 0 failed, 373 expectations.bun typecheckfromsrc/mendcode/packages/opencode— passed.MENDCODE_SMOKE_COLS=80 MENDCODE_SMOKE_ROWS=24 bun run script/session-runtime-smoke.ts --loop-queue-only— passed native PTY coverage for queued notification visibility,Send now, PageUp/PageDown and double-Esc.git diff --check— passed.Screenshots or Recordings
No screenshot is attached. The native PTY smoke passed at 80x24; the exact expanded Shell visual is covered by the reflow regression invariant rather than an automated screenshot.
Checklist