Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a script without gt opened a fresh connection per statement, so anything session-scoped was gone by the next line: SET @var, SET search_path, temp tables. Scripts now run on one connection, and a BEGIN inside the script continues on that same connection instead of opening another.
Checked in the real app, same scripts before and after: SQLite temp table (was "no such table", now returns the row), MariaDB @client_name from #337 (NULL, now '%Example%'), Postgres SET over the SSH tunnel ('' , now the value). Writes are still committed per statement and a failing statement still stops the script with the earlier writes kept, same as before.
Stacked on #339, which routes this executor through the SSH tunnel. Together they close #337.
Closes #337