Repository navigation
Remove INTERNET and ACCESS_NETWORK_STATE from the libre APK - #65
Merged
Merged
Conversation
Strip both permissions in :app only (MarkNotes Plus keeps them via :app-shared) and skip the network callback when no provider exists, so launch cannot throw a SecurityException even if 'Sync when reconnected' is still on. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
main moved sync behind SyncHooks, so the libre app never observes network state; the SyncManager guard and its test are replaced by a permissions test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Summary
:appstripsINTERNETandACCESS_NETWORK_STATEwithtools:node="remove";:app-shared's manifest is unchanged, so MarkNotes Plus keeps both.MainActivity.watchNetwork()returns early unlessSyncManager.canWatchNetwork(providers non-empty), independent of the Sync when reconnected setting, so upgraders from 0.1.x cannot hit aSecurityException.scripts/check-release-apk.pynow expects onlyUSE_BIOMETRICand the AndroidX receiver permission; docs and the F-Droid MR copies updated.Parity impact
MarkNotes Plus is unaffected; it picks this up on its next
libre/bump.Checklist
ktlintCheck detekt lintDebug testDebugUnitTest :core:test assembleDebugpass locally; release APKaapt2 dump permissionslists only the two expected entries🤖 Generated with Claude Code