Skip to content

Parity runner: support fixture appliesTo and an edition key #73

Closed

Description

@MaxDac

Part of the GitHub Issues integration. Design and decisions: ~/.claude/plans/plan-the-inclusion-of-whimsical-rocket.md. Handoff: ~/.claude/plans/github-issues-handoff.md. Contract: marknotes-spec issues.md (on main). Engine: marknotes-sync PR #23 (merged). Web is out of scope; Libre only gets a generic hook.

Work

Libre (and Pro through it) must support fixture appliesTo before the new fixtures/issues/* can be consumed.

  • Bump spec/ to a commit on spec main containing fixtures/issues/* (ea4a41f or newer).
  • Extend the parity runner: a file with appliesTo runs only when it lists the runner's key. Libre's key is android; Pro's is android-pro (the runner must take the edition as a parameter, default android, so Pro can run the issues fixtures against its own module). Excluded files are recognised and reported as skipped; unknown files still fail.
  • Tests: issues fixtures skipped in Libre; an unmapped file still fails; android-pro selects them.
  • Libre has Parity (marknotes-spec fixtures) as a required job; Pro pins Libre, so describe the API change in the PR for the Pro session.

Done when

Libre CI is green with the new pin and the six issues files skipped.

Activity

  1. MaxDac commented on Nov 5, 2026

    @MaxDac
    OwnerAuthor

    PR #75. Differs from the issue: Libre has no spec/ submodule (private spec, public repo), so there is no pin to bump; Pro owns the fixture pin. Verified against spec ea4a41f via -Pmarknotes.specDir. Details in the PR.

  2. MaxDac commented on Nov 5, 2026

    @MaxDac
    OwnerAuthor

    Merged via #75 as b3be41436d54c9a24330070448729331fc6933f1 (on main). Note: Libre has no spec/ submodule and no Parity (marknotes-spec fixtures) job (private spec, public repo); the runner takes -Pmarknotes.specDir. Pro (MarkNotes#58) must set its spec pin to ea4a41f or newer and pass SpecFixtures.PRO_KEY (android-pro) for the issues fixtures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions