Repository navigation
fix: share-link viewer mapping + fakeln callback scheme - #182
Merged
Merged
Conversation
fake_lnurl_metadata built the callback as https:// for any Host that did not start with localhost/127. — but mm-payment treats RFC 6761 names (*.test, *.local, *.localhost) as plain HTTP. A creator address routed via a docker alias (stage@fakestripe.test:8787) got an https:// callback for a plain-HTTP server, so invoice creation failed and the share-link paywall could never settle on the demo path. The scheme now mirrors LightningAddress::is_local_domain exactly, with a unit test pinning the agreement.
ViewerApiClient cast the raw snake_case JSON straight to camelCase
StreamInfo, so stream.active, viewerCount, hostDisplayName and
startedAt were all undefined: every watch page rendered a live
stream as idle ('No active stream'), never joined it, and hid the
host/count. Both getStream and getPublicStream now go through
mapStreamInfo; a regression test pins the mapping against a real
stage response body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes found testing #181 on stage:
Viewer rendered every live stream as idle (share link or not)
ViewerApiClient.getStream/getPublicStreamcast raw snake_caseStreamResponseJSON to camelCaseStreamInfo—active,viewerCount,hostDisplayName,startedAtall undefined. Live streams showed 'No active stream' and never joined.mapStreamInfo; regression test pinned against a real stage response body.Paywall invoice could never settle on the demo path
https://for any Host not starting with localhost/127., while mm-payment treats RFC 6761 names (*.test, *.local, *.localhost) as plain HTTP. A creator address via docker alias (stage@fakestripe.test:8787) got an https:// callback for a plain-HTTP server.LightningAddress::is_local_domainexactly, with a unit test pinning the agreement. mm-fakestripe suites green.