Repository navigation
docs(store): segments are bit-packed 64-quad column blocks since #169, not 16-quad varint deltas - #173
Merged
Conversation
… not 16-quad varint deltas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
docs/store.md and docs/architecture.md still described the quad segments as blocks of 16 quads, each quad a varint delta from the one before. Since #169,
segment.rshas used blocks of at most 64 quads, with each of the four columns bit-packed against the block's smallest value (a frame of reference). The new text follows the module docs ofsegment.rsand the format constants inpersist.rs:OXGSSEG4: blocks first, sizes last (#218).OXGSSEG3: the same blocks, with sizes first.The "Cheaper lookups" benchmark section measured the old blocks. It stays as history, with a note that points to the current layout.
How it was tested
Docs only. Each claim was checked against
crates/tripletrail-store/src/segment.rs(module docs,BLOCK = 64,from_legacy, the delta merge) and theSEG_MAGIC*constants inpersist.rs.Documentation