Skip to content

Pdf reader features #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marvelxy merged 3 commits into from
Oct 21, 2026
Merged

Pdf reader features #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c7cb68
fix: add Frameworks directory to app bundle structure
Marvelxy Oct 20, 2026
5406a4c
fix: pass release config to make-app.sh in CI
Marvelxy Oct 20, 2026
257e9cc
fix: add app-bundle rpath so Sparkle resolves from Contents/Frameworks
Marvelxy Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

- name: Package app bundle
if: startsWith(github.ref, 'refs/tags/v')
run: APP_BINARY=.build/universal/PDFReader APP_VERSION="${GITHUB_REF_NAME}" APP_BUILD="${GITHUB_RUN_NUMBER}" ./scripts/make-app.sh release
run: ./scripts/make-app.sh release release APP_BINARY=.build/universal/PDFReader APP_VERSION="${GITHUB_REF_NAME}" APP_BUILD="${GITHUB_RUN_NUMBER}"

- name: Build DMG
if: startsWith(github.ref, 'refs/tags/v')
Expand Down
10 changes: 9 additions & 1 deletion scripts/make-app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,16 @@ else
fi

rm -rf "$APP_DIR"
mkdir -p "$APP_DIR/Contents/MacOS" "$APP_DIR/Contents/Resources"
mkdir -p "$APP_DIR/Contents/MacOS" "$APP_DIR/Contents/Frameworks" "$APP_DIR/Contents/Resources"
cp "$BIN" "$APP_DIR/Contents/MacOS/PDFReader"
# The binary's Sparkle load command uses @rpath, but SwiftPM only emits
# toolchain rpaths (/usr/lib/swift, …). Without an app-bundle rpath, dyld
# can never resolve @rpath/Sparkle.framework from Contents/Frameworks and
# the app aborts at launch (DYLD "Library missing"). Add it if absent.
EXEC="$APP_DIR/Contents/MacOS/PDFReader"
if ! otool -l "$EXEC" | grep -q 'path @executable_path/../Frameworks'; then
xcrun install_name_tool -add_rpath '@executable_path/../Frameworks' "$EXEC"
fi
# Copy Sparkle framework for update checking
cp -R ".build/$CONFIG/Sparkle.framework" "$APP_DIR/Contents/Frameworks/"
# App icon (generated by scripts/generate-icon.swift).
Expand Down
Loading