Skip to content

🧪 Add tests for loadTrace timings and warnings - #159

Merged
MarsLuay merged 1 commit into
mainfrom
testing-improvements-load-trace-9752482501169696476
Sep 15, 2026
Merged

MarsLuay merged 1 commit into
mainfrom
testing-improvements-load-trace-9752482501169696476

Conversation

@MarsLuay

Copy link
Copy Markdown
Owner

🎯 What: Missing tests for createLoadTrace in loadTrace.ts addressed.
📊 Coverage: monotonicNow fallback logic, relative timing calculations, and debug/warn logs for normal, slow phase, and slow load scenarios are now tested.
Result: Enhanced test coverage that guarantees load traces track relative timings deterministically without polluting test runners.


PR created automatically by Jules for task 9752482501169696476 started by @MarsLuay

Implemented tests to cover the `monotonicNow` and `createLoadTrace` logic in `src/loadTrace.ts`. Ensures fallback from `performance.now` to `Date.now` is tested, and that relative timings (`sinceStartMs`, `sincePreviousMs`) and load completion duration logs work properly.
Copilot AI lite review requested due to automatic review settings September 13, 2026 06:51
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MarsLuay
MarsLuay merged commit 2d17032 into main Sep 15, 2026
0 of 4 checks passed
@MarsLuay
MarsLuay deleted the testing-improvements-load-trace-9752482501169696476 branch September 15, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants