Skip to content

fix: bugs found reviewing the last 10 feature PRs - #372

Merged
timdegroot1996 merged 2 commits into
mainfrom
fix/feature-review-findings
Oct 5, 2026
Merged

timdegroot1996 merged 2 commits into
mainfrom
fix/feature-review-findings

Conversation

@timdegroot1996

Copy link
Copy Markdown
Collaborator

Fixes for bugs found while reviewing #322, #323, #324, #332, #349 and #357. Each one was reproduced first, then covered by a unit test or checked in the generated dashboard.

Overview (#322, #332)

  • Project bars missing for good. When the overview was first opened with a filter active, projects outside the filter never got a bar, even after the filter was cleared. Bars and the saved overview section order are now built from all runs. Bars of projects without runs under the current filter are hidden instead of never created.
  • Rerun line missing with timezone conversion. The "Rerun: x (fixed y)" card line looked up tests by their stored run start, but the cards use the converted one. The lookup now converts the tests the same way and rebuilds when those settings change.

Filters (#357)

  • Histogram bar click dropped runs. The date pickers only carry minutes, and the "to" bound was HH:MM:00. Clicking a bar left out runs from that bar's last minute, e.g. a 02:15:12 run in the 02:15 bar. The "to" minute is now included in full.
  • Custom filter AND mode did nothing different from OR. AND now keeps only runs that have every selected value. A run holds one value per key, so AND matches only while a single value is selected; two or more values give no runs.

Processing (#332)

  • Skipped reruns parsed wrongly. For rebot --merge messages where the rerun was skipped, the stored message kept rebot's Original message: prefix and its HTML escaping. The attempt history before the skip was also lost. Tests now use messages produced by real robot + rebot --merge runs instead of hand-written ones.

Server (#323)

  • Logs with "report" in the name treated as reports. /add-log-file treated any name containing report as a report, so e.g. log-reporting-api.html was never linked to its run. Only a report prefix counts now, and only that prefix is swapped for log when looking for the matching log.

Listener (#324)

  • Crash with --log NONE + uploadlog=true. log_file() is never called then, so the listener raised AttributeError. --output NONE now gives a clear error instead of looking for a file called None.
  • Traceback when the server is down. limit= removal raised a raw traceback if the server was unreachable; it now prints the listener's normal error.

Docs

  • filtering.md: custom filter modes. dashboard-server.md, log-linking.md: report naming.
  • New dark mode README screenshot with stat widgets, a link widget and a custom graph. The custom graph comes from [Feature Request] Custom graphs #255, which is not on main yet.

Testing

  • Python 414 passed, JS 379 passed.
  • Robot (Docker): full suite 124/124 after the script's automatic rerun; "Merge Two Filter Profiles Into A New One" timed out waiting for its modal on the first attempt and passed alone. 06_filters 35/35 after the AND change.

🤖 Generated with Claude Code

timdegroot1996 and others added 2 commits October 5, 2026 23:20
- overview: create a bar for every project, hide empty ones (#322)
- overview: rerun line lookup follows the timezone/milliseconds settings (#332)
- filters: include the whole "to" minute of the date range (#357)
- filters: custom filter AND mode matches runs that have every selected value
- processing: parse skipped-rerun merge messages as rebot writes them (#332)
- server: only a "report" prefix marks an uploaded report (#323)
- listener: no crash with --log/--output NONE or an unreachable server on limit removal (#324)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…dgets

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@timdegroot1996
timdegroot1996 merged commit ae8bd2c into main Oct 5, 2026
3 checks passed
@timdegroot1996
timdegroot1996 deleted the fix/feature-review-findings branch October 5, 2026 22:02
@timdegroot1996 timdegroot1996 mentioned this pull request Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant