Repository navigation
fix: bugs found reviewing the last 10 feature PRs - #372
Merged
Merged
Conversation
- overview: create a bar for every project, hide empty ones (#322) - overview: rerun line lookup follows the timezone/milliseconds settings (#332) - filters: include the whole "to" minute of the date range (#357) - filters: custom filter AND mode matches runs that have every selected value - processing: parse skipped-rerun merge messages as rebot writes them (#332) - server: only a "report" prefix marks an uploaded report (#323) - listener: no crash with --log/--output NONE or an unreachable server on limit removal (#324) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…dgets Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for bugs found while reviewing #322, #323, #324, #332, #349 and #357. Each one was reproduced first, then covered by a unit test or checked in the generated dashboard.
Overview (#322, #332)
Filters (#357)
HH:MM:00. Clicking a bar left out runs from that bar's last minute, e.g. a 02:15:12 run in the 02:15 bar. The "to" minute is now included in full.Processing (#332)
rebot --mergemessages where the rerun was skipped, the stored message kept rebot'sOriginal message:prefix and its HTML escaping. The attempt history before the skip was also lost. Tests now use messages produced by realrobot+rebot --mergeruns instead of hand-written ones.Server (#323)
/add-log-filetreated any name containingreportas a report, so e.g.log-reporting-api.htmlwas never linked to its run. Only areportprefix counts now, and only that prefix is swapped forlogwhen looking for the matching log.Listener (#324)
--log NONE+uploadlog=true.log_file()is never called then, so the listener raisedAttributeError.--output NONEnow gives a clear error instead of looking for a file calledNone.limit=removal raised a raw traceback if the server was unreachable; it now prints the listener's normal error.Docs
filtering.md: custom filter modes.dashboard-server.md,log-linking.md: report naming.mainyet.Testing
06_filters35/35 after the AND change.🤖 Generated with Claude Code