Repository navigation
feat(web): show the Users page to every org - #2324
Conversation
Drop the users rollout flag: the Users row under Analyze always shows and /users no longer redirects orgs outside the rollout home.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Maple review🟢 Confidence 8/10 · likely safe to merge. Flag removal is consistent end to end, but the ungating it introduces has no test pinning it. Removes the
Findings🟠 Warning · F1 · The change's own behavior — Users always shown and reachable — is pinned by no testtests · The Users-row test was deleted rather than inverted, so nothing asserts 🤖 Prompt to fix this finding with an AI agent
|
| titles({ releases: false, securityAudit: false, statusPages: false, users: false }), | ||
| ).not.toContain("Status pages") | ||
| expect(titles({ releases: false, securityAudit: false, statusPages: true, users: false })).toContain( | ||
| expect(titles({ releases: false, securityAudit: false, statusPages: false })).not.toContain( |
There was a problem hiding this comment.
Warning
The change's own behavior — Users always shown and reachable — is pinned by no test
F1 · Warning · tests
The Users-row test was deleted rather than inverted, so nothing asserts navGroups always contains Users, and route.test.ts:130 no longer pins that /users and /users/:id are not redirected. Both files test this kind of code, so the ungating itself is unpinned and a later re-gate would pass CI.
Add `expect(titles({ releases: false, securityAudit: false, statusPages: false })).toContain("Users")` here, and in `route.test.ts` assert `flaggedRouteRedirect(parse("/users"), { statusPages: false })` is `Option.none()`.
🤖 Prompt to fix with an AI agent
In `apps/web/src/shell/nav.test.ts:69-73`: The change's own behavior — Users always shown and reachable — is pinned by no test.
The Users-row test was deleted rather than inverted, so nothing asserts `navGroups` always contains `Users`, and `route.test.ts:130` no longer pins that `/users` and `/users/:id` are not redirected. Both files test this kind of code, so the ungating itself is unpinned and a later re-gate would pass CI.
Suggested fix: Add `expect(titles({ releases: false, securityAudit: false, statusPages: false })).toContain("Users")` here, and in `route.test.ts` assert `flaggedRouteRedirect(parse("/users"), { statusPages: false })` is `Option.none()`.
Verify the problem exists at that location before changing it, and keep the fix to those lines.
Removes the `users` org rollout flag so the Users page is on for everyone.
Orgs with `users: true` in their metadata are unaffected; the unknown key is ignored.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.