Repository navigation
Conversation
The template's clearOverlays() goes through BaseMapViewController.clearOverlayControllers() like the providers, and its conformance test now runs checkClearOverlaysReachesExtensions(), which fails on the old clearOverlays() (extension marker controller cleared 0 times) and passes now. Needs the js-sdk-core change on fix/clear-strategy.
This was referenced Nov 8, 2026
Open
This was referenced Nov 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
clearOverlays()は、各プロバイダが自分で持つコントローラ(マーカー・ポリゴンなど)しか clear していませんでした。クラスタリングなどの拡張が登録する Strategy のコントローラ(StrategyMarkerController)は対象外で、clearOverlays()の後もクラスタのマーカーが地図に残っていました。何を変えたか
react-for-template(雛形)の
clearOverlays()をclearOverlayControllers()経由にしました。雛形の conformance テストでcheckClearOverlaysReachesExtensions()も回します(前のclearOverlays()では、拡張のマーカーコントローラが 0 回しか clear されず落ちます)。js-sdk-core の同名 PR の変更が必要です。
検証
2026-11-08 に develop(fix/mapview-teardown、fix/geodesic-polygon-fill、fix/clear-followups、refactor/polygon-controller などのマージ後)の上に載せ直してから確かめています。
OverlayControllerLike.clear?()の追加のみ。ClearOverlaysStrategy.test.mjsは前の core で落ち、今は通ります。template の conformance テスト(checkClearOverlaysReachesExtensions)も通ります。確認できていないもの
checkClearOverlaysReachesExtensionsが無く落ちます。js-sdk-core の PR のマージと submodule の引き上げの後に通る見込みです。clearOverlayControllers)が要ります。npm 公開と依存の引き上げまでは、公開済みの core に対してビルドできません。関連 PR(
fix/clear-strategyの一式)マージの順番:
fix/overlay-stacking-orderの PR 一式とは衝突しません(git merge-treeで確認済み)。順番は clear-strategy → stacking を想定しています。