Repository navigation
Fix runnable React example documentation snippets - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample documentation currently displays incomplete TSX fragments, undefined data and helpers, and interaction handlers that do not reproduce the demonstrated behavior. Generate standalone
App.tsxexamples with the required imports, stylesheets, inline sample data and appropriate initial cameras.check:snippetsto type-check all 666 supported page/provider combinations and exercise interaction handlers with real SDK state objects. Include the supporting ignore rules, lockfile update and Three.js typings.Validation: snippet type checks and interaction checks pass; repository lint passes with an existing HERE declaration warning. The examples client/SSR build and static generation passed. Chrome checks covered ten core examples and the extension examples in the local Studio, including GeoJSON/KML property clicks, heatmap rendering, cluster expansion, vector-style color changes and Three.js rendering.
The existing app-wide TypeScript errors outside the generated documentation snippets remain out of scope.