Repository navigation
Show URL-loaded ImageIcon and ground image in the sample - #14
Merged
Merged
Conversation
The Marker page gets a fifth row with ImageIcon(imageUrl:). The Ground Image page gets a "Load from URL" button (also --groundImageUrl at launch); tapping the image switches back to the bundled images, which clears imageUrl. Points ios-sdk-core at the URL-loading change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
ImageIcon(imageUrl:)andGroundImageState(bounds:imageUrl:)from MapConductor/ios-sdk-core#24 (merged) and pointsios-sdk-coreat that merge.ImageIcon(imageUrl:)(tokyo.pngfrom the public react-sdk repo).--groundImageUrl); tapping the image goes back to the bundled images.Also fixes the ios-sdk-core pointer on develop. The merge 2489086 recorded
a899663f7662…, which doesn't exist (the real commit isa89966317662…), sogit submodule updateon develop fails. This PR moves it to b03d6b9.Verified on iPad (iPad8,4): URL icon appears on MapLibre, MapKit, Google Maps and Mapbox; URL ground image on MapLibre and Google Maps.