Repository navigation
Put the version into the marker tile URL - #22
Merged
Merged
Conversation
urlTemplate(routeId:version:) dropped the version, so the URL never changed. Tiles are served with a long Cache-Control, and the map kept the tiles it had already drawn: a marker change reached only tiles that came into view later, and a label crossing a seam was cut where the neighbour was still the old picture. MapLibre, Mapbox, MapTiler and Mappls build their URL this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
LocalTileServer.urlTemplate(routeId:version:)now putsversioninto the URL path (.../v{version}/{z}/{x}/{y}.png). Before this, it threwversionaway and returned the same URL every time.The deprecation message now points to
urlTemplate(routeId:tileSize:cacheKey:). The old message recommendedurlTemplate(routeId:tileSize:), which has no version either.Why
Cache-Control.MapLibre, Mapbox, MapTiler and Mappls build their marker tile URL with this method.
Checked
On an iPad, with the street-tree sample (144k markers) on MapLibre: