Repository navigation
Center a side label on the pin, not on its head - #18
Merged
Merged
Conversation
With the label beside the pin (left / right), center lined it up with the head's center, 0.35 of the icon down, so it sat well above the middle of the pin and did not look centered. It is now halfway between the pin's top and its tip, midway between top and bottom. center center and the labels above or below are unchanged. Same change as js-sdk-core#11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 版の MapConductor/js-sdk-core#11 と同じ変更です。
不具合
labelPositionがleft center/right centerのとき、ラベルがピンの中央に見えない（上に寄る）。原因
横に置いたときの
centerは、ピンの頭（丸い部分）の中心（アイコンの高さの 0.35）に揃えていた。ピン全体（上端〜先端）の中間より、48 px のピンで約 7 px 上になる。修正
横に置くときの
centerを、ピンの上端と先端の中間にした。top（上端に揃える）とbottom（先端に揃える）の、ちょうど中間になる。ドキュメントコメントも合わせた。ピンの頭に重ねる
center center（既定）と、上下に置くcenter top/center bottomは変えていない。確認
xcodebuild test（シミュレータ、316 件すべて通過）testSideCenterIsHalfwayDownThePin（横に置いた center は、ピンの上端と先端の中間）。修正を外すと失敗することを確認した。