Repository navigation
Keep the map design across configuration changes - #11
Merged
Merged
Conversation
- TomTomMapView never applied the state's design to the map (it used the MapOptions default) and the controller's default (Standard) was reported to the state on listener attach, so a passed-in or restored design became Standard. The design is applied first, then the listener attached. - The saver kept only the id; Custom designs (StyleDescriptor) and attribution rules were lost. It now saves the descriptor (Parcelable). - Device round-trip test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapOptions default) and the controller's default (Standard) was reported
to the state on listener attach, so a passed-in or restored design became
Standard. The design is applied first, then the listener attached.
attribution rules were lost. It now saves the descriptor (Parcelable).
After a configuration change (screen rotation) the map state now keeps its design (id, style, attribution rules), uiSettings and camera paddings. Depends on android-sdk-core
MapViewStateBundle; merge order core → compose → providers. Verified by rotating a Lenovo tablet (HA26Z6JL); instrumented tests pass the saved Bundle through a real Parcel.