Repository navigation
Remove overlay markers in clearOverlays() - #14
Merged
Merged
Conversation
clearOverlays() cleared the shape and raster controllers and the marker tiles, but not the list of markers drawn as overlays (MapTilerMarkerOverlay), so markers below the tiling threshold stayed on the map after clearOverlays() (seen on the tablet). It now empties that list first, as the Longdo controller does.
This was referenced Nov 8, 2026
Merged
Stop resync from rewriting sources and layers that did not change
MapConductor/react-for-maplibre#27
Merged
Merged
Stop resync from rewriting sources and layers that did not change
MapConductor/react-for-maptiler#18
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
MapTilerMapViewController.clearOverlays()が、オーバーレイ経路のマーカー一覧（_markers）を空にしていなかったので、clearOverlays()の後もマーカーが残っていました。何を変えたか
clearOverlays()で_markersを空にして地図から外すようにしました。3 プラットフォームの全プロバイダの
clearOverlays()を洗い出し、漏れが見つかったのはこの MapTiler と android-for-tomtom の 2 本だけでした。検証
タブレット（HA26Z6JL）の検証用ページで「追加 → 更新 → 一部削除 → 戻す → clearOverlays() → その場で書き換え → 送り直す」を撮りました。直す前はマーカーが clear 後も残り、直した後は消え、送り直すと戻ります。実機の地図オブジェクトが要るため、単体テストは足していません。
既知の別件（この PR では直していません）: 一度外したポリゴン・サークル・ラスターが戻らない問題は develop の時点からあり、別の変更で直します。
関連 PR（
fix/clear-followupsの一式）それぞれ独立していて、マージの順番の制約はありません（web の変更は js-sdk-core の新しい版を必要としません）。