Repository navigation
Use the core reapplyStyle() for raster layers - #9
Merged
Merged
Conversation
MapplsRasterLayerController.reapplyStyle() read the manager outside the controller lock and registered what it read again. Drop it and use the one in android-sdk-core's RasterLayerController (MapConductor/android-sdk-core#17), which runs under the lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapConductor/android-sdk-core#17 に依存します。そちらを先にマージしてください。
MapplsRasterLayerController.reapplyStyle()を消し、android-sdk-core の基底クラスのreapplyStyle()を使います。こちらはロックの中で動き、entity の登録もし直しません。呼び出し側（スタイルの読み込み後のrasterLayerController.reapplyStyle()）は変わりません。不具合と修正の詳細は android-sdk-core#17 にあります。いまの renderer は中断しないので、実際には起きていません。先に塞いでおくための修正です。
api/android-for-mappls.apiからreapplyStyle()が消えた（基底クラスから継承）確認
:android-for-mappls:compileDebugKotlinと:android-for-mappls:apiCheckが通る