Repository navigation
Redraw a marker when its URL icon's image arrives - #10
Merged
Merged
Conversation
ImageIcon(imageUrl = ...) keeps the same instance when its image arrives; only its hashCode changes, and MarkerState makes the icon read recompose. Key the remembered bitmap on the hash as well, or the overlay keeps the transparent placeholder.
MarkerState.icon no longer reads Compose state; iconRevision is the counter that goes up when a URL icon's image arrives. Reading it also makes the overlay recompose then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Longdo marker overlay remembers the marker bitmap per icon. A URL
ImageIcon(MapConductor/android-sdk-core#23, merged) is the same object before and after its image arrives, so the overlay kept drawing the transparent placeholder.The bitmap is now keyed on
marker.iconandmarker.iconRevision.iconRevisionis Compose state that core bumps when the icon's image arrives, so reading it also makes the overlay recompose at that moment.Verified on TB520FU with an icon URL delayed by 8 s: only the label at ~5 s, the icon at ~15 s.