Skip to content

Interpolate the closing edge of polygons, geodesic or not #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wf9a5m75 merged 2 commits into from
Nov 8, 2026
Merged

Interpolate the closing edge of polygons, geodesic or not #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df9c80
Interpolate the closing edge of geodesic polygons
wf9a5m75 Nov 8, 2026
79b9f43
Densify non-geodesic polygon rings, closing edge included
wf9a5m75 Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions src/main/java/com/mapconductor/here/polygon/HerePolygonOverlayRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.mapconductor.core.ResourceProvider
import com.mapconductor.core.features.GeoPoint
import com.mapconductor.core.features.GeoPointInterface
import com.mapconductor.core.features.GeoRectBounds
import com.mapconductor.core.geometry.densifyPolygonRing
import com.mapconductor.core.normalizeLng
import com.mapconductor.core.polygon.AbstractPolygonOverlayRenderer
import com.mapconductor.core.polygon.PolygonEntityInterface
Expand Down Expand Up @@ -237,31 +238,20 @@ class HerePolygonOverlayRenderer(
points: List<GeoPointInterface>,
geodesic: Boolean,
): List<GeoCoordinates> =
(
if (geodesic) {
com.mapconductor.core.spherical
.WGS84Geodesic
.createInterpolatePoints(points)
} else {
points
}
).map { GeoCoordinates(it.latitude, normalizeLng(it.longitude)) }
// 閉じる辺（末尾 → 先頭）も他の辺と同じく補間する（塗りと輪郭が同じネイティブポリゴン）。
// geodesic は大圏、geodesic=false は緯度経度の線形補間（ポリラインの false と同じ線）。
densifyPolygonRing(points, geodesic)
.map { GeoCoordinates(it.latitude, normalizeLng(it.longitude)) }
.let { pts -> if (pts.size >= 2 && pts.first() == pts.last()) pts.dropLast(1) else pts }

/** [toRing] と同じ補間・正規化を、分割へ渡すため GeoPointInterface のまま返す。 */
private fun toGeoRing(
points: List<GeoPointInterface>,
geodesic: Boolean,
): List<GeoPointInterface> =
(
if (geodesic) {
com.mapconductor.core.spherical
.WGS84Geodesic
.createInterpolatePoints(points)
} else {
points
}
).map { GeoPoint(latitude = it.latitude, longitude = normalizeLng(it.longitude)) }
// 閉じる辺（末尾 → 先頭）も他の辺と同じく補間する（塗りと輪郭が同じネイティブポリゴン）。
// geodesic は大圏、geodesic=false は緯度経度の線形補間（ポリラインの false と同じ線）。
densifyPolygonRing(points, geodesic).map { GeoPoint(latitude = it.latitude, longitude = normalizeLng(it.longitude)) }

private fun boundsOf(points: List<GeoPointInterface>): GeoRectBounds? {
if (points.isEmpty()) return null
Expand Down
Loading