Repository navigation
feat(options): set stay details, photos, website and the trip budget from flags - #12
Merged
Merged
Conversation
`options add` and `options edit` take --details and --photos, and `trips edit` takes --budget. Each takes JSON, and null clears the field. The mna skill now tells models to record a stay detail only when it helps choose between a trip's options, never to state what is equally true of all of them, never to invent a fact, and to say where a fact came from when that is not obvious. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R6BF2tkLhdyAHNtHx1mtCK
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R6BF2tkLhdyAHNtHx1mtCK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
mna options addandmna options edittake--details '<json>'and--photos '<json>', for accommodation only. On edit, each works without--from-json.mna options addandeditalso take--website <url>, the place's own official site, for accommodation only.mna trips edittakes--budget '<json>'.nullclears any of them.mnaskill and its reference now explain these fields. A model should add a stay detail only when it helps choose between this trip's options, should not state what is equally true of all of them, must not invent facts, and should say where a fact came from when that isn't obvious.Event
priceOptionsneed no new flag: they go through the existing--from-json, and the skill now documents them.Merge order
This needs
akoso/travel-plans#164deployed first. Until then, the server rejects these fields as unknown on most routes.openapi.jsonis not refreshed here, for the same reason. The request bodies are already cast, so the code doesn't depend on it.No tag or release is included.
Testing
bun test(229 pass),bun run typecheckandbun run lintall pass. None of this has run against a real server; the tests stubfetch.🤖 Generated with Claude Code
https://claude.ai/code/session_01R6BF2tkLhdyAHNtHx1mtCK