Skip to content

feat(reranker): salvage PR52 scale floor plus holdout calibration - #63

Merged
ManSio merged 1 commit into
mainfrom
feat/pr52-salvage
Sep 29, 2026
Merged

ManSio merged 1 commit into
mainfrom
feat/pr52-salvage

Conversation

@ManSio

@ManSio ManSio commented Sep 29, 2026

Copy link
Copy Markdown
Owner

Salvage of the non-conflicting parts of conflicting PR52 (which is superseded for P2 by merged P54).

  • Sigmoid normalization of llama.cpp raw logits to [0,1] (without it MIN_RERANK_SCORE=0.3 cuts 70-97pct of output incl. targets).
  • Top-N recall floor reranker_topn_keep (default 0 = off): union of threshold passers with top-N by score.
  • Holdout threshold calibration with eval sources rejected by code (ValueError), not by comment.

Deliberately SKIPPED: anchor_tier_winners - P2 is covered by merged P54 (_anchor_identifier_chunks_async) at the same pool site; a second P2 mechanism without its own A/B would be a violation. Branch PR52 kept as reference.

Verified: 58 reranker tests + 125 across searcher/bs_audit/hybrid suites green, ruff clean.

From conflicting PR52 (supserseded by merged P54 for P2): sigmoid
normalization of llama.cpp raw logits to [0,1] (else MIN_RERANK_SCORE
cuts 70-97pct incl. targets), top-N recall floor reranker_topn_keep
(default 0 = off), holdout threshold calibration with eval sources
rejected by code. Tier-winner anchors deliberately skipped: P2 covered
by merged P54 at the same pool site. Guards: 4 sigmoid + 13 floor tests.
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b385ef86-b376-4d41-a45e-b085b25dbc57


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ManSio
ManSio merged commit 404238a into main Sep 29, 2026
12 of 13 checks passed
@ManSio

ManSio commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Note for reviewers: on #58 merge, this PR's _sigmoid hunk replaces #58's naive version (overflow past |x|>~709) with the numerically stable one + P-002 extremes test. Plan agreed with owner: #58 first, then rebase here. Tier-winner anchors intentionally out (P2 covered by #54).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant