Skip to content

fix(redteam): wire silent_subprocess into entry point, close red-team tails - #57

Merged
ManSio merged 1 commit into
mainfrom
fix/redteam-tails
Sep 29, 2026
Merged

ManSio merged 1 commit into
mainfrom
fix/redteam-tails

Conversation

@ManSio

@ManSio ManSio commented Sep 29, 2026

Copy link
Copy Markdown
Owner

Closes the two leftovers from PR #56 report.

(a) silent_subprocess was INERT — wired into entry point (src/main.py import + apply() at startup, as the module docstring requires). Reference check: stash vor-fix-unstaged (stash@{2}) contains no src/main.py wiring, so implemented the minimal import+apply directly.

  • Hardening found by the liveness test: apply() now guards TypeError for non-class Popen (conftest test-shims replace Popen with a plain function; without the guard the startup import would fail under pytest).
  • Liveness proof: tests/test_silent_subprocess_wired.py spawns a fresh interpreter (immune to conftest shims), imports src.main, asserts _APPLIED + Popen=_SilentPopen on win32.

(b) KNOWN_ISSUES.md reconciled: 3x 2026-09-28 red-team entries (Open)/(Fixed-pending-verification) -> Fixed with fix SHA 0b6ca7c + merge e8811af (PR #56 CI all green). The 2026-09-28 retriever-cache methodology rule stays Open honestly (not a code fix).

Evidence: affected suites 13/13 green (silent 3 + wired 1 + hook 3 + holdout 6); full suite 1941 passed, 6 skipped; ruff check clean (format drift in touched files is pre-existing at HEAD, hunks are clean).
DO NOT MERGE — for owner review.

… tails

- src/main.py imports silent_subprocess + apply() at startup (module was INERT since PR #56)
- silent_subprocess.apply(): TypeError guard for non-class Popen (test shims)
- tests/test_silent_subprocess_wired.py: fresh-process liveness (Popen=_SilentPopen on win32)
- KNOWN_ISSUES.md: 3x 2026-09-28 red-team entries (Open) -> Fixed with SHAs (PR #56 merged e8811af, CI green)
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0060bb61-31eb-46c1-9c49-99e344c405ef


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ManSio
ManSio merged commit e5756f5 into main Sep 29, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant