fix(redteam): wire silent_subprocess into entry point, close red-team tails - #57
Merged
Merged
Conversation
… tails - src/main.py imports silent_subprocess + apply() at startup (module was INERT since PR #56) - silent_subprocess.apply(): TypeError guard for non-class Popen (test shims) - tests/test_silent_subprocess_wired.py: fresh-process liveness (Popen=_SilentPopen on win32) - KNOWN_ISSUES.md: 3x 2026-09-28 red-team entries (Open) -> Fixed with SHAs (PR #56 merged e8811af, CI green)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two leftovers from PR #56 report.
(a) silent_subprocess was INERT — wired into entry point (src/main.py import + apply() at startup, as the module docstring requires). Reference check: stash vor-fix-unstaged (stash@{2}) contains no src/main.py wiring, so implemented the minimal import+apply directly.
(b) KNOWN_ISSUES.md reconciled: 3x 2026-09-28 red-team entries (Open)/(Fixed-pending-verification) -> Fixed with fix SHA 0b6ca7c + merge e8811af (PR #56 CI all green). The 2026-09-28 retriever-cache methodology rule stays Open honestly (not a code fix).
Evidence: affected suites 13/13 green (silent 3 + wired 1 + hook 3 + holdout 6); full suite 1941 passed, 6 skipped; ruff check clean (format drift in touched files is pre-existing at HEAD, hunks are clean).
DO NOT MERGE — for owner review.