Skip to content

add Web platform landing page and PWA setup instructions - #558

Merged
nschimme merged 1 commit into
MUME:masterfrom
nschimme:master
Sep 14, 2026
Merged

nschimme merged 1 commit into
MUME:masterfrom
nschimme:master

Conversation

@nschimme

@nschimme nschimme commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor
  • Create docs/web.md as a landing page for MMapper Web matching desktop platforms.
  • Provide direct link to launch MMapper Web and a collapsible Web Beta section.
  • Add PWA installation instructions for iOS (Safari) and Android (Chrome).
  • Update homepage (docs/index.md) Web platform link to point to /web.html.

Summary by Sourcery

Add a dedicated Web platform landing page and guide users through launching and installing MMapper as a PWA.

New Features:

  • Add a dedicated MMapper Web landing page with a direct launch link, PWA installation guidance, mobile keyboard recommendations, and access to beta builds.

Enhancements:

  • Improve the site script with touch-device styling and platform-aware highlighting for PWA instructions.

Documentation:

  • Update the homepage Web platform link to use the new Web landing page.

- Create docs/web.md as a landing page for MMapper Web matching desktop platforms.
- Provide direct link to launch MMapper Web and a collapsible Web Beta section.
- Add PWA installation instructions for iOS (Safari) and Android (Chrome).
- Update homepage (docs/index.md) Web platform link to point to /web.html.
@sourcery-ai

sourcery-ai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

The PR introduces a dedicated Web landing page at /web.html, providing a direct launch link, PWA installation instructions, mobile keyboard guidance, and access to beta builds. It also updates the homepage link and extends the shared site JavaScript with touch and mobile-platform detection to emphasize relevant guidance.

File-Level Changes

Change Details Files
Adds a dedicated Web platform landing page with launch access, PWA guidance, mobile keyboard guidance, and beta-build discovery.
  • Creates the Web landing page and links it to the production demo.
  • Documents iOS Safari and Android Chrome PWA installation steps.
  • Adds a collapsible section for beta/development builds and a touch-device keyboard notice.
  • Updates the homepage Web platform link to the new landing page.
docs/web.md
docs/index.md
Consolidates site JavaScript and adds device-aware page enhancements.
  • Renames the loaded script to site.js while retaining existing site behavior.
  • Highlights the keyboard notice on touch devices.
  • Detects iOS and Android devices, reorders the iOS PWA instructions on iOS, and highlights the relevant platform section.
docs/_layouts/default.html
docs/assets/js/download-highlight.js
docs/assets/js/site.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@nschimme
nschimme merged commit 82928e6 into MUME:master Sep 14, 2026
19 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.27%. Comparing base (b4d8d58) to head (6533c69).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   27.27%   27.27%           
=======================================
  Files         559      559           
  Lines       45912    45912           
  Branches     4879     4879           
=======================================
  Hits        12522    12522           
  Misses      33390    33390           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant