Skip to content

fix GMCP error caused by forwarding External.Discord.Get to MUME #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nschimme wants to merge 9 commits into from
Closed

fix GMCP error caused by forwarding External.Discord.Get to MUME #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5325046
Fix GMCP error caused by External.Discord.Get
nschimme Aug 20, 2026
5890c75
Fix GMCP error caused by External.Discord.Get
nschimme Aug 20, 2026
05c02d3
Fix GMCP error caused by External.Discord.Get
nschimme Sep 14, 2026
2d2e5de
Fix GMCP error caused by External.Discord.Get
nschimme Sep 14, 2026
1336574
Fix GMCP error caused by External.Discord.Get
nschimme Sep 14, 2026
f3cc103
Add EXTERNAL_DISCORD_GET GMCP message type
nschimme Sep 14, 2026
9ae3e68
Add EXTERNAL_DISCORD_GET GMCP message type
nschimme Sep 14, 2026
d904945
Add EXTERNAL_DISCORD_GET GMCP message type
nschimme Sep 14, 2026
f5245d8
Add EXTERNAL_DISCORD_GET GMCP message type
nschimme Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/proxy/GmcpMessage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class ParseEvent;
X(EVENT_MOVED, EventMoved, "event.moved", "Event.Moved") \
X(EVENT_MOON, EventMoon, "event.moon", "Event.Moon") \
X(EVENT_SUN, EventSun, "event.sun", "Event.Sun") \
X(EXTERNAL_DISCORD_GET, ExternalDiscordGet, "external.discord.get", "External.Discord.Get") \
X(EXTERNAL_DISCORD_HELLO, \
ExternalDiscordHello, \
"external.discord.hello", \
Expand Down Expand Up @@ -66,7 +67,7 @@ enum class NODISCARD GmcpMessageTypeEnum {
#define X_COUNT(...) +1
static constexpr const size_t NUM_GMCP_MESSAGES = XFOREACH_GMCP_MESSAGE_TYPE(X_COUNT);
#undef X_COUNT
static_assert(NUM_GMCP_MESSAGES == 30);
static_assert(NUM_GMCP_MESSAGES == 31);
DEFINE_ENUM_COUNT(GmcpMessageTypeEnum, NUM_GMCP_MESSAGES)

namespace tags {
Expand Down
4 changes: 1 addition & 3 deletions src/proxy/proxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,9 +544,7 @@ void Proxy::allocMudTelnet()
}
void virt_onMumeClientError(const QString &errmsg) final
{
qInfo() << errmsg;
getProxy().sendToUser(SendToUserSourceEnum::FromMMapper,
QString("MUME.Client protocol error: %1").arg(errmsg));
qWarning() << "MUME.Client protocol error:" << errmsg;
}
};

Expand Down
6 changes: 6 additions & 0 deletions tests/TestProxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ void TestProxy::gmcpMessageDeserializeTest()
GmcpMessage gmcp3 = GmcpMessage::fromRawBytes(R"(External.Discord.Hello)");
QCOMPARE(gmcp3.getName().toQByteArray(), QByteArray("External.Discord.Hello"));
QVERIFY(!gmcp3.getJson());
QVERIFY(gmcp3.isExternalDiscordHello());

GmcpMessage gmcp4 = GmcpMessage::fromRawBytes(R"(External.Discord.Get)");
QCOMPARE(gmcp4.getName().toQByteArray(), QByteArray("External.Discord.Get"));
QVERIFY(!gmcp4.getJson());
QVERIFY(gmcp4.isExternalDiscordGet());
}

void TestProxy::gmcpMessageSerializeTest()
Expand Down
Loading