Add option to set min resolution below sea level within a geojson hull - #974
Open
trhille wants to merge 2 commits into
Open
Add option to set min resolution below sea level within a geojson hull#974trhille wants to merge 2 commits into
trhille wants to merge 2 commits into
Conversation
build_cell_width accepts a 'min_spac_geojson' config option pointing to a lon/lat geojson hull. Within that hull, cell spacing is set to min_spac everywhere the bed is below sea level, via a new geojson_to_grid_mask helper and a hull_mask term in set_cell_width. The Antarctica step passes its projection so the hull vertices can be transformed to the gridded coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_cell_width accepts a 'min_spac_geojson' config option pointing to a lon/lat geojson hull. Within that hull, cell spacing is set to min_spac everywhere the bed is below sea level, via a new geojson_to_grid_mask helper and a hull_mask term in set_cell_width. The Antarctica step passes its projection so the hull vertices can be transformed to the gridded coordinates.
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes