Seed AIS bed flood fill from open ocean - #973
Open
trhille wants to merge 1 commit into
Open
Conversation
The Antarctica mesh-gen step seeded the bed-topography flood fill at the grid center, which is thick interior ice far from any grounding line. The high_dist_bed cap zeroes that cell, so gridded_flood_fill returned an empty mask and use_bed produced no refinement on the full ice sheet. Add a 'flood_fill_start=auto' mode to build_cell_width that seeds the flood fill from the deepest ice-free, below-sea-level (open ocean) cell, chosen by data values so it is independent of grid resolution. Use it in the Antarctica step. Existing callers using [None, None] or an explicit seed are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Antarctica mesh-gen step seeded the bed-topography flood fill at the grid center, which is thick interior ice far from any grounding line. The high_dist_bed cap zeroes that cell, so gridded_flood_fill returned an empty mask and use_bed produced no refinement on the full ice sheet.
Add a 'flood_fill_start=auto' mode to build_cell_width that seeds the flood fill from the deepest ice-free, below-sea-level (open ocean) cell, chosen by data values so it is independent of grid resolution. Use it in the Antarctica step. Existing callers using [None, None] or an explicit seed are unchanged.
Checklist
Testingin this PR) any testing that was used to verify the changes