ci: run the full test matrix against the release branch - #121
Merged
jdhughes-dev merged 1 commit intoSep 6, 2026
Merged
Conversation
A bot pushes the release branch and opens the release pull request, and neither a push nor a pull_request event fires for a bot using the workflow token, so the 1.0.1 pull request carried no checks at all. Preparing the release ran a single job's worth of tests in passing, which is not the matrix that guards develop. Continuous integration is now callable and takes the ref to test, and the release workflow calls it against the branch it just pushed. Preparing the release no longer runs tests itself, and the pull request is drafted in a separate job that waits for the matrix, so a release that fails the tests never reaches review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bot pushes the release branch and opens the release pull request, and neither a push nor a
pull_requestevent fires for a bot using the workflow token. The 1.0.1 release pull request carried no checks at all —no checks reported on the 'v1.0.1' branch. Preparing the release ran one job's worth of tests in passing, which is not the matrix that guardsdevelop.ci.ymlgains aworkflow_calltrigger and an optionalrefinput, threaded through every checkout. Empty means the triggering ref, so push and pull_request behaviour is unchanged.release.ymlcalls it against the branch prep just pushed, and no longer runs tests insideprep.run_tests: falsestill skips the matrix, and the pull request is still drafted.The called workflow uses a distinct concurrency group so it cannot cancel the release that started it.