fix(dependencies): require a pandas that supports numpy 2 - #118
Merged
Conversation
pandas below 2.1 declares no upper bound on numpy, so pandas>=1.5 let a resolver pair pandas 1.5.3 with numpy 2 and produce an environment that fails on import pandas with "numpy.dtype size changed, may indicate binary incompatibility". Installing modflowapi 1.0.0 alongside a pinned pandas<2 reproduced it. 2.2.2 is the first release that supports numpy 2 rather than capping it, so resolution no longer has to drag numpy back to 1.x. The package uses only DataFrame.from_records and to_records, which are unchanged, so the bound is about the numpy pairing and not about the pandas API. conda-forge is unaffected, since its packages carry numpy ABI constraints.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pandas below 2.1 declares no upper bound on numpy, so
pandas>=1.5let a resolver pair pandas 1.5.3 with numpy 2 and produce an environment that fails onimport pandas:2.2.2 is the first release that supports numpy 2 rather than capping it, so resolution no longer has to drag numpy back to 1.x. The package uses only
DataFrame.from_recordsandto_records, which are unchanged since pandas 0.x and verified working on 1.5.3, so this is about the numpy pairing rather than the pandas API.conda-forge is unaffected: its packages carry numpy ABI constraints, and
mamba create modflowapi=1.0.0 "pandas<2"correctly resolves numpy 1.26.4.