Repository navigation
Conversation
Only the /spark/ prefix (duplicate slashes collapsed) reaches Spark code; every other path, including none, is the PSBT signer exactly as before. Spark responses use the NSpark.RemoteSigner envelope and status codes; no seed is enabled for Spark yet, so every wallet gets a 403. The KMS client is now injectable (Function(Func<IAmazonKeyManagementService>)), so the whole handler runs in CI against a fake KMS: the routing tests check non-Spark paths still produce the golden PSBT byte-for-byte and Spark paths never touch KMS. The fake KMS moves to its own file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/spark/...requests to the new Spark code; every other request is the PSBT signer, unchanged.Stack created with GitHub Stacks CLI • Give Feedback 💬