Skip to content

fix/SaveLastOpenFilesList() - #692

Open
Pr0metheus2 wants to merge 1 commit into
LogExperts:Developmentfrom
Pr0metheus2:fix/SaveLastOpenFilesList()
Open

fix/SaveLastOpenFilesList()#692
Pr0metheus2 wants to merge 1 commit into
LogExperts:Developmentfrom
Pr0metheus2:fix/SaveLastOpenFilesList()

Conversation

@Pr0metheus2

@Pr0metheus2 Pr0metheus2 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fix for clearing "LastOpenFilesList" on app exit.
When app closes, it looks like it wipes the set of files to restore.

Before exit:
image

After exit:
image

1. SaveLastOpenFilesList() clears LastOpenFilesList.
  2. It receives an empty list from GetAllWindowsFromDockPanel().
  3. Nothing is added back.
  4. The empty list is saved to settings.json.
@Hirogen

Hirogen commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

looks good, but pls change your indent style from tab to spaces.
Pls also add a unit test for this case [TabControllerTests.cs] should be the right class

Also change the inner for to an foreach, the for is not needed

@Pr0metheus2

Copy link
Copy Markdown
Contributor Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants