Conversation
Widen api-platform/symfony (and the dev requirement api-platform/core) to also accept ^5.0. No source changes are needed. symfony/http-client is added as a dev requirement: with API Platform 5 the functional test kernel fails to compile without it (TestClientPass loads ApiPlatform\Symfony\Bundle\Test\Client, which uses HttpClientTrait). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bundle cannot be installed alongside API Platform 5:
api-platform/symfonyis constrained to^3.4 || ^4.0, so Composer refuses to resolve a project that requiresapi-platform/core:^5.0.Changes
api-platform/symfony(and the dev requirementapi-platform/core) to^3.4 || ^4.0 || ^5.0. No source changes were needed.symfony/http-clientas a dev requirement. With API Platform 5.0.2 the functional test kernel fails to compile without it:TestClientPassloadsApiPlatform\Symfony\Bundle\Test\Client, which usesHttpClientTrait(Error: Trait "Symfony\Component\HttpClient\HttpClientTrait" not found, 7 tests inConfigurationTest).Verification
Run locally on PHP 8.5.10:
bin/phpunit: 100 tests, 209 assertions, OKbin/phpstan analyse: no errorsbin/php-cs-fixer check: nothing to fixcomposer validate --strict: validcomposer update --with api-platform/core:^4.0):bin/phpunit: 100 tests, 209 assertions, OKNot run locally: the PHP 8.2 /
--prefer-lowestjob (API Platform 3.4); that is left to CI.🤖 Generated with Claude Code