Repository navigation
fix(linux): keep virtual Xbox controllers on hid-generic - #192
Open
ReenigneArcher wants to merge 1 commit into
Open
ReenigneArcher wants to merge 1 commit into
ReenigneArcher wants to merge 1 commit into
Conversation
Mark the upper word of the UHID vendor ID to prevent xpadneo and its udev rules from claiming virtual Xbox One and Series devices. Preserve the consumer-visible Xbox identity, Guide chords, trigger rumble, and battery reporting. Add kernel identity assertions and SDL2/SDL3 Guide chord regression coverage. Validate with 144 unit tests and five native consumer tests with xpadneo Guide shift mode enabled. Fixes #191
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 73.77% 73.77% -0.01%
==========================================
Files 43 43
Lines 10697 10702 +5
Branches 3693 3695 +2
==========================================
+ Hits 7892 7895 +3
+ Misses 2442 2159 -283
- Partials 363 648 +285
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mark the upper word of the UHID vendor ID to prevent xpadneo and its udev rules from claiming virtual Xbox One and Series devices. Preserve the consumer-visible Xbox identity, Guide chords, trigger rumble, and battery reporting.
Add kernel identity assertions and SDL2/SDL3 Guide chord regression coverage.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Validated with 144 unit tests and five native consumer tests with xpadneo Guide shift mode enabled.
Type of Change
Checklist
AI Usage
See our AI usage policy.