Skip to content

docker: give the image a healthcheck it can actually run #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m4bard wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

docker: give the image a healthcheck it can actually run #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,11 @@ COPY docker-entrypoint.sh /docker-entrypoint.sh
RUN sh /tmp/listenarr-runtime/prepare-entrypoint.sh \
&& rm -rf /tmp/listenarr-runtime

# Report container health from the application's own readiness probe. The runtime
# image ships no HTTP client - curl and gnupg are purged after the Discord bot
# install and wget was never present - so the request is issued with the node
# binary that the bot runtime already puts in the image.
HEALTHCHECK --interval=30s --timeout=5s --start-period=90s --retries=3 \
CMD ["node", "-e", "require('http').get('http://127.0.0.1:4545/api/v1/system/ready', res => process.exit(res.statusCode === 200 ? 0 : 1)).on('error', () => process.exit(1))"]

ENTRYPOINT ["/docker-entrypoint.sh"]
7 changes: 7 additions & 0 deletions listenarr.api/Dockerfile.runtime
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,11 @@ COPY docker-entrypoint.sh /docker-entrypoint.sh
RUN sh /tmp/listenarr-runtime/prepare-entrypoint.sh \
&& rm -rf /tmp/listenarr-runtime

# Report container health from the application's own readiness probe. The runtime
# image ships no HTTP client - curl and gnupg are purged after the Discord bot
# install and wget was never present - so the request is issued with the node
# binary that the bot runtime already puts in the image.
HEALTHCHECK --interval=30s --timeout=5s --start-period=90s --retries=3 \
CMD ["node", "-e", "require('http').get('http://127.0.0.1:4545/api/v1/system/ready', res => process.exit(res.statusCode === 200 ? 0 : 1)).on('error', () => process.exit(1))"]

ENTRYPOINT ["/docker-entrypoint.sh"]